Re: [PATCH] ftrace: ftrace dump on oops control

[Randy Dunlap <randy.dunlap@oracle.com>]

On Thu, 23 Oct 2008 15:15:27 -0400 (EDT) Steven Rostedt wrote:

> +/**
> + * ftrace_dump_on_oops - variable to dump ftrace buffer on oops
> + *
> + * If there is an oops (or kernel panic) and the ftrace_dump_on_oops
> + * is set, then ftrace_dump is called. This will output the contents
> + * of the ftrace buffers to the console.  This is very useful for
> + * capturing traces that lead to crashes and outputing it to a
> + * serial console.
> + *
> + * It is default off, but you can enable it with either specifying
> + * "ftrace_dump_on_oops" in the kernel command line, or setting
> + * /proc/sys/kernel/ftrace_dump_on_oops to true.
> + */
> +int ftrace_dump_on_oops;

Hi Steven,

Please lose the /** (just use /*).  The documentation is a good thing,
but we don't do kernel-doc for simple variables.
That might be a good thing to add one day....

---
~Randy