From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756535AbYJXOd1 (ORCPT ); Fri, 24 Oct 2008 10:33:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752530AbYJXOdT (ORCPT ); Fri, 24 Oct 2008 10:33:19 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55343 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbYJXOdS (ORCPT ); Fri, 24 Oct 2008 10:33:18 -0400 Date: Fri, 24 Oct 2008 12:33:15 -0200 From: Mauro Carvalho Chehab To: Takashi Iwai Cc: Laurent Pinchart , linux-kernel@vger.kernel.org, airlied@linux.ie, perex@perex.cz, alan-jenkins@tuffmail.co.uk Subject: Re: [PATCH] Check fops_get() return value Message-ID: <20081024123315.5ca3bc83@pedra.chehab.org> In-Reply-To: References: <200810161502.41159.laurent.pinchart@skynet.be> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.4; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Oct 2008 15:28:00 +0200 Takashi Iwai wrote: > > > > old_fops = filp->f_op; > > filp->f_op = fops_get(&dev->driver->fops); > > + if (filp->f_op == NULL) { > > I think the more standard style is > > if (!file->fop) { Yes. This seems a good cleanup to the patch. > > Except for that minor issue, it looks good to me. > In any case, > > Acked-by: Takashi Iwai You have my ack also. Acked-by: Mauro Carvalho Chehab Cheers, Mauro