From: Alexey Dobriyan <adobriyan@gmail.com>
To: Alistair John Strachan <alistair@devzero.co.uk>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.28-rc1
Date: Fri, 24 Oct 2008 17:13:40 +0400 [thread overview]
Message-ID: <20081024131340.GB24358@x200.localdomain> (raw)
In-Reply-To: <200810241352.45745.alistair@devzero.co.uk>
On Fri, Oct 24, 2008 at 01:52:45PM +0100, Alistair John Strachan wrote:
> On Friday 24 October 2008 12:45:04 Rafael J. Wysocki wrote:
> > On Friday, 24 of October 2008, Alistair John Strachan wrote:
> > > On Friday 24 October 2008 05:10:29 Linus Torvalds wrote:
> > > > It's been two weeks, so it's time to close the merge window. A
> > > > 2.6.28-rc1 is out there, and it's hopefully all good.
> > >
> > > It seems if you have a broken asm/ symlink in include/ (which happened as
> > > a result of the x86 header moves, for me) the kernel won't try to update
> > > it appropriately, and this breaks "make prepare".
> > >
> > > $ make ARCH=x86_64 prepare
> > > CHK include/linux/version.h
> > > CHK include/linux/utsrelease.h
> > > GEN include/asm/asm-offsets.h
> > > /bin/sh: include/asm/asm-offsets.h: No such file or directory
> > > make[1]: *** [include/asm/asm-offsets.h] Error 1
> > > make: *** [prepare0] Error 2
> > >
> > > rm -f include/asm fixes it
> > >
> > > This was just from taking a 2.6.27 tree, git clean -d -f, git pull, make
> > > oldconfig. Might be a nice thing to fix?
> >
> > Hm, I didn't have any problems with compiling .28-rc1 on x86_64.
> >
> > [Confused.]
>
> This should reproduce it (whether or not it's a use-case we care about is
> another matter). First, make sure your include/asm symlink has been removed,
> then execute the following sequence:
>
> git reset --hard v2.6.27 ; git clean -d -f
> git status ("Nothing to commit")
>
> cp /path/to/config .config
> make oldconfig prepare
> git clean -d -f ; git reset --hard
> git status ("Nothing to commit")
>
> Observe at this point that include/asm is valid and points to include/asm-x86,
> despite the clean and reset (I guess this file is being ignored). Now:
>
> git reset --hard v2.6.28-rc1 (Or whatever other method you might choose)
> git clean -d -f (Removes include/asm-x86)
>
> Observe at this point that include/asm is now invalid, and still points to the
> removed include/asm-x86 directory.
>
> cp /path/to/config .config
> make oldconfig prepare
>
> Should fail at this point:
>
> scripts/kconfig/conf -o arch/x86/Kconfig
> #
> # configuration written to .config
> #
> scripts/kconfig/conf -s arch/x86/Kconfig
> CHK include/linux/version.h
> UPD include/linux/version.h
> CHK include/linux/utsrelease.h
> UPD include/linux/utsrelease.h
> CC kernel/bounds.s
> GEN include/linux/bounds.h
> CC arch/x86/kernel/asm-offsets.s
> GEN include/asm/asm-offsets.h
> /bin/sh: include/asm/asm-offsets.h: No such file or directory
> make[2]: *** [include/asm/asm-offsets.h] Error 1
> make[1]: *** [prepare0] Error 2
> make: *** [prepare] Error 2
>
> Can you confirm?
>
> I checked out Makefile and I believe it occurs because the current checks only
> make sure a symlink exists, and if it does exist that its target matches up
> with the selected architecture. It doesn't actually check the destination of
> the symlink is valid.
>
> I'd suggest that it should do that too, and if the destination doesn't exist,
> re-write the symlink when it does "mkdir include/asm-x86" further down, but
> I'm not a kbuild expert.
Use this script for super-clean project-agnostic clean:
$ cat ~/bin/git-mrproper
#!/bin/sh
git-ls-files -o --directory -z | xargs -0 rm -rf
I'd say nothing should be done here, include/asm symlink autochange
because of different ARCH was unsupported due to it being "big" event, and
headers move is equally "big" event.
next prev parent reply other threads:[~2008-10-24 13:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 4:10 Linus Torvalds
2008-10-24 4:14 ` Roland Dreier
2008-10-24 18:08 ` Greg KH
2008-10-24 11:24 ` Alistair John Strachan
2008-10-24 11:45 ` Rafael J. Wysocki
2008-10-24 12:52 ` Alistair John Strachan
2008-10-24 13:13 ` Alexey Dobriyan [this message]
2008-10-24 14:56 ` git-clean [Was: Linux 2.6.28-rc1] Björn Steinbrink
2008-10-24 15:17 ` Linux 2.6.28-rc1 Linus Torvalds
2008-10-24 19:22 ` Sam Ravnborg
2008-10-24 22:31 ` David Miller
2008-10-24 22:51 ` Sam Ravnborg
2008-10-24 19:15 ` Sam Ravnborg
2008-10-24 23:44 ` Alistair John Strachan
2008-10-24 17:09 ` Matt Mackall
2008-10-24 17:54 ` Matt Mackall
2008-10-24 17:57 ` Randy Dunlap
2008-10-24 18:05 ` Fenghua Yu
2008-10-24 18:11 ` Matt Mackall
2008-10-24 22:28 ` nf_conntrack oopes on parisc/smp (was Re: Linux 2.6.28-rc1) Domenico Andreoli
2008-10-24 22:53 ` Linux 2.6.28-rc1 Tony Vroon
2008-10-24 23:01 ` Arjan van de Ven
2008-10-26 13:17 ` Tony Vroon
2008-10-30 14:26 ` 2.6.28-rc1: NVRAM being corrupted on ppc64 preventing boot (bisected) Mel Gorman
2008-10-30 20:52 ` Paul Mackerras
2008-10-30 21:05 ` Josh Boyer
2008-10-30 21:35 ` Dave Kleikamp
2008-10-31 10:36 ` Mel Gorman
2008-10-31 11:10 ` Paul Mackerras
2008-10-31 11:31 ` Mel Gorman
2008-10-31 18:36 ` Mel Gorman
2008-10-31 11:18 ` Paul Mackerras
2008-10-31 11:31 ` Benjamin Herrenschmidt
2008-10-31 11:56 ` Paul Mackerras
2008-10-31 11:32 ` Mel Gorman
2008-10-24 18:10 Linux 2.6.28-rc1 Rufus & Azrael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024131340.GB24358@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=alistair@devzero.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®