From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Roman Zippel <zippel@linux-m68k.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/timex.h: cleanup for userspace
Date: Mon, 27 Oct 2008 20:28:27 -0700 [thread overview]
Message-ID: <20081027202827.30e6c038.akpm@linux-foundation.org> (raw)
In-Reply-To: <1225017451-19133-1-git-send-email-vapier@gentoo.org>
On Sun, 26 Oct 2008 06:37:31 -0400 Mike Frysinger <vapier@gentoo.org> wrote:
> Move all the kernel-specific defines and includes into the __KERNEL__
> section so that they don't get leaked into userspace.
>
checkpatch correctly instructs us to use linux/param.h, not asm/param.h.
This:
--- a/include/linux/timex.h~linux-timexh-cleanup-for-userspace-checkpatch-fixes
+++ a/include/linux/timex.h
@@ -165,8 +165,8 @@ struct timex {
#ifdef __KERNEL__
#include <linux/compiler.h>
#include <linux/types.h>
+#include <linux/param.h>
-#include <asm/param.h>
#include <asm/timex.h>
/*
_
seems Obviously Safe to me. Do you agree?
(please use checkpatch - sometimes it's useful!)
next prev parent reply other threads:[~2008-10-28 3:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 10:37 Mike Frysinger
2008-10-28 3:28 ` Andrew Morton [this message]
2008-10-28 3:31 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2008-12-27 6:49 Mike Frysinger
2008-12-29 12:22 ` Mike Frysinger
2008-08-20 2:46 Mike Frysinger
2008-08-21 3:09 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027202827.30e6c038.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®