From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Jonathan Cameron <jic23@cam.ac.uk>
Cc: eric miao <eric.y.miao@gmail.com>, Liam Girdwood <lrg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Regulator RFC] da903x: Where should usb charge pump support go?
Date: Tue, 28 Oct 2008 13:23:41 +0200 [thread overview]
Message-ID: <20081028112341.GF27144@gandalf.research.nokia.com> (raw)
In-Reply-To: <4906F500.7080100@cam.ac.uk>
On Tue, Oct 28, 2008 at 11:18:24AM +0000, ext Jonathan Cameron wrote:
> Dear All,
>
> The new da903x driver is proving to be a good replacement for the out of kernel
> driver I've been using previously.
>
> Unfortunately there is still quite a lot of functionality to to add.
>
> The key one for me is control of the USB charge pump. So the question is, does
> this fit within the regulator framework (i.e. should I add it to the regulator
> driver) or should this be a seperate driver (and if so where?)
>
> Personally I'm not convinced it fits cleanly within the regulator framework
> given it is probably only ever going to get called from one driver and has
> somewhat odd properties!
I was thinking the same and even mailed Liam and Mark about it. The
design I was thinking was the charger chip would be done in regulator
framework and the battery chip (or current gauge) would be using power
supply fw and regulator consumer device.
The constraints would be basically the current and/or voltage range your
charger chip supports.
I still didn't have much time to hack on it, but seemed to be pretty
reasonable.
If someone has better idea, I'd trully like to hear that.
--
balbi
next prev parent reply other threads:[~2008-10-28 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 11:18 Jonathan Cameron
2008-10-28 11:23 ` Felipe Balbi [this message]
2008-10-28 12:03 ` Liam Girdwood
2008-10-29 12:18 ` Jonathan Cameron
2008-10-29 12:27 ` Mark Brown
2008-10-29 12:48 ` Jonathan Cameron
2008-10-29 13:05 ` Mark Brown
2008-10-29 13:21 ` Mike Rapoport
2008-10-28 11:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028112341.GF27144@gandalf.research.nokia.com \
--to=felipe.balbi@nokia.com \
--cc=eric.y.miao@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®