From: Manuel Traut <manut@linutronix.de>
To: hjk@linutronix.de
Cc: b.spranger@linutronix.de, gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: UIO: don't check irq_enabled flag in uio_cif irq handler
Date: Tue, 28 Oct 2008 23:41:37 +0100 [thread overview]
Message-ID: <20081028224137.GA25357@www.tglx.de> (raw)
Below patch ignores INT1_ENABLED flag in the uio_cif irq handler.
On a Hilscher DeviceNet Slave card, the INT_ENABLE flag is (probably) reseted
by the firmware. Without this patch, every interrupt produced by this card is
dropped.
This patch is tested and works with a DeviceNet Slave and a Profibus Slave card.
Signed-off-by: Manuel Traut <manut@linutronix.de>
--- linux-git/drivers/uio/uio_cif.c 2008-10-28 23:42:18.000000000 +0100
+++ uio/drivers/uio/uio_cif.c 2008-10-28 23:41:43.000000000 +0100
@@ -18,7 +18,6 @@
#define PLX9030_INTCSR 0x4C
#define INTSCR_INT1_ENABLE 0x01
#define INTSCR_INT1_STATUS 0x04
-#define INT1_ENABLED_AND_ACTIVE (INTSCR_INT1_ENABLE | INTSCR_INT1_STATUS)
#define PCI_SUBVENDOR_ID_PEP 0x1518
#define CIF_SUBDEVICE_PROFIBUS 0x430
@@ -30,8 +29,8 @@
void __iomem *plx_intscr = dev_info->mem[0].internal_addr
+ PLX9030_INTCSR;
- if ((ioread8(plx_intscr) & INT1_ENABLED_AND_ACTIVE)
- != INT1_ENABLED_AND_ACTIVE)
+ if ((ioread8(plx_intscr) & INT1_STATUS)
+ != INT1_STATUS)
return IRQ_NONE;
/* Disable interrupt */
next reply other threads:[~2008-10-28 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 22:41 Manuel Traut [this message]
2008-10-29 20:10 ` Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028224137.GA25357@www.tglx.de \
--to=manut@linutronix.de \
--cc=b.spranger@linutronix.de \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®