Re: [PATCH] Power Management support requires RTC_CLASS

[Randy Dunlap <randy.dunlap@oracle.com>]

On Fri, 31 Oct 2008 00:04:07 +0900 Yoichi Yuasa wrote:

> kernel/built-in.o: In function `test_wakealarm':
> linux/kernel/power/main.c:619: undefined reference to `rtc_read_time'
> linux/kernel/power/main.c:619: relocation truncated to fit: R_MIPS_26 against `rtc_read_time'
> linux/kernel/power/main.c:630: undefined reference to `rtc_set_alarm'
> linux/kernel/power/main.c:630: relocation truncated to fit: R_MIPS_26 against `rtc_set_alarm'
> linux/kernel/power/main.c:654: undefined reference to `rtc_set_alarm'
> linux/kernel/power/main.c:654: relocation truncated to fit: R_MIPS_26 against `rtc_set_alarm'
> kernel/built-in.o: In function `test_suspend':
> linux/kernel/power/main.c:718: undefined reference to `rtc_class_open'
> linux/kernel/power/main.c:718: relocation truncated to fit: R_MIPS_26 against `rtc_class_open'
> linux/kernel/power/main.c:726: undefined reference to `rtc_class_close'
> linux/kernel/power/main.c:726: relocation truncated to fit: R_MIPS_26 against `rtc_class_close'
> kernel/built-in.o: In function `valid_state':
> linux/kernel/power/main.c:403: undefined reference to `rtc_class'
> kernel/built-in.o: In function `test_suspend':
> linux/kernel/power/main.c:716: undefined reference to `rtc_class'
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> 
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/kernel/power/Kconfig linux/kernel/power/Kconfig
> --- linux-orig/kernel/power/Kconfig	2008-10-22 09:41:32.154425163 +0900
> +++ linux/kernel/power/Kconfig	2008-10-22 11:04:48.230018848 +0900
> @@ -1,6 +1,7 @@
>  config PM
>  	bool "Power Management support"
>  	depends on !IA64_HP_SIM
> +	select RTC_CLASS
>  	---help---
>  	  "Power Management" means that parts of your computer are shut
>  	  off or put into a power conserving "sleep" mode if they are not
> --

That should only be needed for the code block that is surrounded by

#ifdef CONFIG_PM_TEST_SUSPEND
...
#endif /* CONFIG_PM_TEST_SUSPEND */

and the Kconfig file already contains

config PM_TEST_SUSPEND
	bool "Test suspend/resume and wakealarm during bootup"
	depends on SUSPEND && PM_DEBUG && RTC_LIB=y

so maybe that needs to be changed to use RTC_CLASS.  I dunno.

---
~Randy