From: Pierre Ossman <drzeus@drzeus.cx>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: mmc: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Thu, 30 Oct 2008 10:09:57 +0100 [thread overview]
Message-ID: <20081030100957.6cba7174@mjolnir.drzeus.cx> (raw)
In-Reply-To: <1225331284.5496.12.camel@brick>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Wed, 29 Oct 2008 18:48:04 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> A lot of these helpers don't seem to add that much, would you care for
> a patch removing them Pierre?
>
> Specifically sdio_func_id, sdio_get/set_drvdata don't have that many
> users.
>
> mmc_hostname has a lot of users, but if you're agreeable, I could
> take a crack at that too.
>
As Marcel said, they provide a nice abstraction (even if it is indeed
a bit silly to have wrappers around wrappers around ..). It also tends
to make the code a bit more readable.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-10-30 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 1:20 Kay Sievers
2008-10-30 1:48 ` Harvey Harrison
2008-10-30 4:37 ` Marcel Holtmann
2008-10-30 5:15 ` Harvey Harrison
2008-10-30 9:09 ` Pierre Ossman [this message]
2008-10-30 9:06 ` Pierre Ossman
2008-10-30 9:21 ` Kay Sievers
2009-01-25 22:50 Kay Sievers
2009-02-02 20:09 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030100957.6cba7174@mjolnir.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=greg@kroah.com \
--cc=harvey.harrison@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®