From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbYJaKpX (ORCPT ); Fri, 31 Oct 2008 06:45:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750741AbYJaKpK (ORCPT ); Fri, 31 Oct 2008 06:45:10 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38505 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbYJaKpJ (ORCPT ); Fri, 31 Oct 2008 06:45:09 -0400 Date: Fri, 31 Oct 2008 06:44:55 -0400 From: Jeff Layton To: Randy Dunlap Cc: Steve French , linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: mmotm 2008-10-30-02-23 uploaded (cifs) Message-ID: <20081031064455.29eb2285@tleilax.poochiereds.net> In-Reply-To: <490A8C16.6040207@oracle.com> References: <200810300924.m9U9OPqK030938@imap1.linux-foundation.org> <20081030181427.bad789f5.randy.dunlap@oracle.com> <524f69650810302013t76027b12i105214daf651ce6a@mail.gmail.com> <490A8C16.6040207@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Oct 2008 21:39:50 -0700 Randy Dunlap wrote: > Steve French wrote: > > On Thu, Oct 30, 2008 at 8:14 PM, Randy Dunlap wrote: > >> On Thu, 30 Oct 2008 02:24:25 -0700 akpm@linux-foundation.org wrote: > >> > >>> The mm-of-the-moment snapshot 2008-10-30-02-23 has been uploaded to > >>> > >>> http://userweb.kernel.org/~akpm/mmotm/ > >>> > >>> It contains the following patches against 2.6.28-rc2: > >> fs/cifs/connect.c: In function 'cifs_mount': > >> fs/cifs/connect.c:2180: error: request for member 'sin_addr' in something not a structure or union > >> > >> rand-config attached. > > > > These line numbers don't match anywhere close to what I expect to find > > in -mm based on the contents of fs/cifs in cifs-2.6.git tree. My > > guess is that has a cifs patch from Jeff Layton, not in cifs-2.6.git > > which may have other dependencies, and in any case IIRC has since been > > removed from -mm but if not that patch may be the problem. > > > > The closest line I have is: > > > > sprintf(pSesInfo->serverName, "%u.%u.%u.%u", > > NIPQUAD(sin_server.sin_addr.s_addr)); > > > > and since sin_server is defined as > > struct sockaddr_in sin_server; > > that should be fine. > > I can't tell you whether this is in cifs.git, but the erring lines are: > > tcon = > find_unc(sin_server.sin_addr.s_addr, volume_info.UNC, > volume_info.username); > > where sin_server.sin_addr should be sin_server->sin_addr. > > HTH. This looks like a goof on my part. I have a later patch in this series that eliminates that call. In an earlier patch series, these patches were in reverse order and I neglected to fix this when I reordered the series. I think Andrew ended up dropping this patch from -mm for the time being. It's going to need modification anyway due to other changes, so it's probably best that it find its way to mainline via his tree. Thanks, -- Jeff Layton