From: Sripathi Kodi <sripathik@in.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH] Inline double_unlock_balance()
Date: Wed, 5 Nov 2008 18:57:14 +0530 [thread overview]
Message-ID: <200811051857.14944.sripathik@in.ibm.com> (raw)
Hi,
We have a test case which measures the variation in the amount of time
needed to perform a fixed amount of work on the preempt_rt kernel. We
started seeing deterioration in it's performance recently. The test
should never take more than 10 microseconds, but we started 5-10%
failure rate. Using elimination method, we traced the problem to commit
1b12bbc747560ea68bcc132c3d05699e52271da0 (lockdep: re-annotate
scheduler runqueues). When LOCKDEP is disabled, this patch only adds an
additional function call to double_unlock_balance(). Hence I inlined
double_unlock_balance() and the problem went away. Here is a patch to
make this change.
Thanks,
Sripathi.
lockdep: Inline double_unlock_balance()
Additional function call for double_unlock_balance() causes latency
problems for some test cases on the preempt_rt kernel.
Signed-off-by: Sripathi Kodi <sripathik@in.ibm.com>
Index: linux-2.6.27.4/kernel/sched.c
===================================================================
--- linux-2.6.27.4.orig/kernel/sched.c 2008-11-05 05:01:01.000000000 -0800
+++ linux-2.6.27.4/kernel/sched.c 2008-11-05 05:01:20.000000000 -0800
@@ -2812,7 +2812,7 @@
return ret;
}
-static void double_unlock_balance(struct rq *this_rq, struct rq *busiest)
+static inline void double_unlock_balance(struct rq *this_rq, struct rq *busiest)
__releases(busiest->lock)
{
spin_unlock(&busiest->lock);
next reply other threads:[~2008-11-05 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 13:27 Sripathi Kodi [this message]
2008-11-05 13:59 ` Peter Zijlstra
2008-11-06 7:32 ` Ingo Molnar
2008-11-06 7:53 ` Peter Zijlstra
2008-11-06 17:30 ` Dhaval Giani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811051857.14944.sripathik@in.ibm.com \
--to=sripathik@in.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®