From: Sebastian Andrzej Siewior <bigeasy@breakpoint.cc>
To: Jeff Garzik <jeff@garzik.org>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: add test vectors for skein256/512/1024
Date: Wed, 5 Nov 2008 22:27:48 +0100 [thread overview]
Message-ID: <20081105212748.GA4990@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <490E5788.4080300@garzik.org>
* Jeff Garzik | 2008-11-02 20:44:40 [-0500]:
> Sebastian Andrzej Siewior wrote:
>> I grabed them from http://www.schneier.com/skein.html. The last test
>> vector
>> (3) in every category is currently deactivated because it failed always.
>> It is unlikely that I made a type because I copy+pasted the tables + vim
>> magiced them. So maybe code may missbehave on requests lengths which are
>> not a multiple of 4 or the vectors can not be used due to some other
>> limitations that I've overseen.
Okay, that was a false positive :)
The "untouched" reference implementation outputs the same hash. The
additional information (tree, ...) is part of the third argument in
Skein_XXX_InitExt() which isn't used. So we can safely drop the third
test vector.
>
> Jeff
Sebastian
next prev parent reply other threads:[~2008-11-05 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 16:15 [PATCH] crypto: Add Skein hash algorithm variants Jeff Garzik
2008-11-02 20:15 ` [PATCH] crypto: add test vectors for skein256/512/1024 Sebastian Andrzej Siewior
2008-11-03 1:36 ` Jeff Garzik
2008-11-03 1:44 ` Jeff Garzik
2008-11-03 8:38 ` Sebastian Andrzej Siewior
2008-11-05 21:27 ` Sebastian Andrzej Siewior [this message]
2008-11-03 0:33 ` [PATCH] crypto: Add Skein hash algorithm variants David Wagner
2008-11-04 16:47 ` ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081105212748.GA4990@Chamillionaire.breakpoint.cc \
--to=bigeasy@breakpoint.cc \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®