From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Miller <davem@davemloft.net>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
wli@holomorphy.com, sparclinux@vger.kernel.org
Subject: Re: tty warning
Date: Thu, 6 Nov 2008 15:35:55 +1100 [thread overview]
Message-ID: <20081106153555.ed45a874.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20081105.202557.233628145.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Hi Dave,
On Wed, 05 Nov 2008 20:25:57 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 6 Nov 2008 15:24:21 +1100
>
> > These are things like:
> >
> > termios->c_cc[VTIME] = 0;
> >
> > termios is a (struct ktermios *) which has "cc_t c_cc[NCCS];". NCCS is
> > 17 and VTIME is also 17. I assume the intention is to actually fill in
> > _x_cc[0], but why is it done this way and not more directly?
>
> It's just some historical stuff.
>
> I've tried to rectify it, but it is non-trivial to fix and
> all it does is pacify a warning rather than fix a real problem
> so... ;-)
>
> This has been brought up perhaps 5 or 6 times in the past half
> year :)
Yeah, I guess that is when the compilers started complaining.
Oh, well :-(
[BTW, the number of warnings is itself becoming a real problem ... :-( ]
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-06 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 4:24 Stephen Rothwell
2008-11-06 4:25 ` David Miller
2008-11-06 4:35 ` Stephen Rothwell [this message]
2008-11-06 10:18 ` Alan Cox
2008-11-06 11:52 ` Robert Reif
2008-11-13 7:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106153555.ed45a874.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®