mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Ken Chen <kenchen@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] enable wchan config menu item for x86-64
Date: Thu, 6 Nov 2008 22:25:40 +0100	[thread overview]
Message-ID: <20081106212540.GE24579@elte.hu> (raw)
In-Reply-To: <b040c32a0811061110g69b6cc6cta88774b72e5b9163@mail.gmail.com>


* Ken Chen <kenchen@google.com> wrote:

> Ingo,
> 
> I don't know when will you phase out /proc/pid/wchan.  Can we enable the
> wchan config menu item for now on x86-64 arch?  This will at least allow
> people to enable/disable frame pointers on scheduler functions.
> 
> Signed-off-by: Ken Chen <kenchen@google.com>
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e60c59b..38f9fb9 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -367,7 +367,7 @@ config X86_RDC321X
>  config SCHED_NO_NO_OMIT_FRAME_POINTER
>  	def_bool y
>  	prompt "Single-depth WCHAN output"
> -	depends on X86_32
> +	depends on X86

makes sense, i've added it to tip/sched/core, thanks Ken!

This will need some testing as we never did this on 64-bit, so it's 
definitely a v2.6.29 item.

	Ingo

      reply	other threads:[~2008-11-06 21:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 19:10 Ken Chen
2008-11-06 21:25 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081106212540.GE24579@elte.hu \
    --to=mingo@elte.hu \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®