From: David Brownell <david-b@pacbell.net>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Victor <linux@maxim.org.za>,
Kevin Hilman <khilman@deeprootsystems.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH/RFC] hardware irq debouncing support
Date: Fri, 7 Nov 2008 14:56:58 -0800 [thread overview]
Message-ID: <200811071456.58921.david-b@pacbell.net> (raw)
In-Reply-To: <20081012144638.4dfdbff8@hskinnemo-gx745.norway.atmel.com>
On Sunday 12 October 2008, Haavard Skinnemoen wrote:
> I just want a mechanism where you'll end up with the same behaviour
> regardless of what the hardware supports, at the cost of a timer if the
> hardware doesn't support the requested debounce delay. As an added
> benefit, this would eliminate the need for drivers to set up their own
> debounce timers. It would also make such "more powerful" hardware
> features easier to utilize from generic drivers, wouldn't it?
>
> But you've convinced me that your IRQF_DEBOUNCE hint might be useful
> too.
Just for the record ... I'm withdrawing this proposal, in the sense
that I won't be pursuing it any further. A lighter weight solution
is enough for now.
I think the framework we discussed -- lowlevel irq_chip mechanism
that can kick in hardware debouncing and report the duration of its
debounce delay, paired with upper level code that can kick in longer
software timers as needed -- is probably the right direction to go,
if anyone really needs this.
> > If the platform setup code knows the hardware debounce will
> > be requested, it can adjust its platform_data debounce parameter
> > accordingly.
>
> I guess it could, but why would it do that? The debounce delay
> shouldn't depend on the mechanism used to implement it, should it?
The overall delay shouldn't matter, no. But if an 10 msec hardware
debounce kicks in and you wanted 20 msec total, you'd want something
to conclude that a 10 msec software timer is more appropriate than
a 20 msec one. I was pointing out that in one construction, that
"something" would be platform setup code which knows more about how
the system is set up than a "dumb" software timer in that driver.
- Dave
next prev parent reply other threads:[~2008-11-07 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 19:51 David Brownell
2008-10-03 7:38 ` Tony Lindgren
2008-10-03 8:45 ` David Brownell
2008-10-03 13:06 ` Tony Lindgren
2008-10-03 9:22 ` Haavard Skinnemoen
2008-10-07 18:14 ` David Brownell
2008-10-08 7:48 ` Haavard Skinnemoen
2008-10-09 9:34 ` David Brownell
2008-10-09 10:30 ` Haavard Skinnemoen
2008-10-11 14:36 ` Pavel Machek
2008-10-11 18:01 ` David Brownell
2008-10-12 12:46 ` Haavard Skinnemoen
2008-11-07 22:56 ` David Brownell [this message]
2008-10-06 15:10 ` Pavel Machek
2008-10-07 17:19 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811071456.58921.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=haavard.skinnemoen@atmel.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®