From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753745AbYKGIrn (ORCPT ); Fri, 7 Nov 2008 03:47:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751396AbYKGIre (ORCPT ); Fri, 7 Nov 2008 03:47:34 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:46726 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbYKGIrd (ORCPT ); Fri, 7 Nov 2008 03:47:33 -0500 From: KOSAKI Motohiro To: Markus Dahms Subject: Re: [linux-next] possible circular locking dependency for cryptsetup Cc: kosaki.motohiro@jp.fujitsu.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20081107083200.GA5109@vimes.madsworld.lan> References: <20081107083200.GA5109@vimes.madsworld.lan> Message-Id: <20081107174526.F874.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Fri, 7 Nov 2008 17:47:26 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi I already fixed this bug. its patch queued in mm tree, now. (file name is mm-remove-lru_add_drain_all-from-the-munlock-path) I expect it merge to mainline soon. Thanks! > Hi there, > > I got the following warning for 2.6.28-rc3-next-20081106, it's quiet for > 2.6.28-rc3. Besides the new warning everything seems to work fine. > > As a side note, I wanted to file this at bugzilla.k.o, but there is no > "next" tree in "alternate trees" - intended? > > FWIW: x86, 2xP3 > > Greetings, > > Markus > > ======================================================= > [ INFO: possible circular locking dependency detected ] > 2.6.28-rc3-next-20081106-mad-1 #2 > ------------------------------------------------------- > cryptsetup/2554 is trying to acquire lock: > (&cpu_hotplug.lock){--..}, at: [] get_online_cpus+0x22/0x40 > > but task is already holding lock: > (&mm->mmap_sem){----}, at: [] sys_mlockall+0x5e/0xd0 > > which lock already depends on the new lock. > > > the existing dependency chain (in reverse order) is: > > -> #3 (&mm->mmap_sem){----}: > [] __lock_acquire+0xf30/0x17f0 > [] lock_acquire+0x5e/0x80 > [] might_fault+0x5c/0x80 > [] copy_to_user+0x36/0x120 > [] filldir64+0xa4/0xf0 > [] sysfs_readdir+0x129/0x220 > [] vfs_readdir+0x95/0xb0 > [] sys_getdents64+0x69/0xc0 > [] sysenter_do_call+0x12/0x31 > [] 0xffffffff > > -> #2 (sysfs_mutex){--..}: > [] __lock_acquire+0xf30/0x17f0 > [] lock_acquire+0x5e/0x80 > [] mutex_lock_nested+0xb4/0x2c0 > [] sysfs_addrm_start+0x2c/0xb0 > [] create_dir+0x40/0x90 > [] sysfs_create_dir+0x2b/0x50 > [] kobject_add_internal+0xcf/0x240 > [] kobject_add_varg+0x31/0x50 > [] kobject_init_and_add+0x27/0x30 > [] sysfs_slab_add+0x83/0x1a0 > [] sysfs_add_func+0x4e/0x70 > [] run_workqueue+0xe5/0x1f0 > [] worker_thread+0x88/0xf0 > [] kthread+0x3c/0x70 > [] kernel_thread_helper+0x7/0x18 > [] 0xffffffff > > -> #1 (slub_lock){----}: > [] __lock_acquire+0xf30/0x17f0 > [] lock_acquire+0x5e/0x80 > [] down_read+0x37/0x50 > [] slab_cpuup_callback+0x3a/0x192 > [] notifier_call_chain+0x2d/0x70 > [] __raw_notifier_call_chain+0x19/0x20 > [] _cpu_up+0x5e/0x105 > [] cpu_up+0x64/0x7b > [] kernel_init+0xb6/0x173 > [] kernel_thread_helper+0x7/0x18 > [] 0xffffffff > > -> #0 (&cpu_hotplug.lock){--..}: > [] __lock_acquire+0x1061/0x17f0 > [] lock_acquire+0x5e/0x80 > [] mutex_lock_nested+0xb4/0x2c0 > [] get_online_cpus+0x22/0x40 > [] schedule_on_each_cpu+0x38/0xe0 > [] lru_add_drain_all+0xd/0x10 > [] __mlock_vma_pages_range+0x36/0x1f0 > [] mlock_fixup+0x10f/0x210 > [] do_mlockall+0x8b/0xa0 > [] sys_mlockall+0x91/0xd0 > [] sysenter_do_call+0x12/0x31 > [] 0xffffffff > > other info that might help us debug this: > > 1 lock held by cryptsetup/2554: > #0: (&mm->mmap_sem){----}, at: [] sys_mlockall+0x5e/0xd0 > > stack backtrace: > Pid: 2554, comm: cryptsetup Not tainted 2.6.28-rc3-next-20081106-mad-1 #2 > Call Trace: > [] ? printk+0x18/0x1e > [] print_circular_bug_tail+0xc3/0xd0 > [] ? print_circular_bug_entry+0x4b/0x50 > [] __lock_acquire+0x1061/0x17f0 > [] lock_acquire+0x5e/0x80 > [] ? get_online_cpus+0x22/0x40 > [] mutex_lock_nested+0xb4/0x2c0 > [] ? get_online_cpus+0x22/0x40 > [] ? get_online_cpus+0x22/0x40 > [] ? __percpu_alloc_mask+0xa1/0x100 > [] get_online_cpus+0x22/0x40 > [] schedule_on_each_cpu+0x38/0xe0 > [] ? lru_add_drain_per_cpu+0x0/0x10 > [] lru_add_drain_all+0xd/0x10 > [] __mlock_vma_pages_range+0x36/0x1f0 > [] ? avc_has_perm+0x59/0x70 > [] mlock_fixup+0x10f/0x210 > [] do_mlockall+0x8b/0xa0 > [] sys_mlockall+0x91/0xd0 > [] sysenter_do_call+0x12/0x31 > > -- > ubuntu is an ancient african word meaning "i can't install debian." > -- unknown > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/