From: Alexey Dobriyan <adobriyan@gmail.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Eduard Munteanu <eduard.munteanu@linux360.ro>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH-ugly] kmemtrace: casting a gfp_t requires __force
Date: Fri, 7 Nov 2008 23:41:14 +0300 [thread overview]
Message-ID: <20081107204114.GA4150@x200.localdomain> (raw)
In-Reply-To: <1226087429.11596.53.camel@brick>
On Fri, Nov 07, 2008 at 11:50:29AM -0800, Harvey Harrison wrote:
> --- a/include/linux/kmemtrace.h
> +++ b/include/linux/kmemtrace.h
> @@ -31,10 +31,10 @@ static inline void kmemtrace_mark_alloc_node(enum kmemtrace_type_id type_id,
> int node)
> {
> trace_mark(kmemtrace_alloc, "type_id %d call_site %lu ptr %lu "
> - "bytes_req %lu bytes_alloc %lu gfp_flags %lu node %d",
> + "bytes_req %lu bytes_alloc %lu gfp_flags %u node %d",
> type_id, call_site, (unsigned long) ptr,
> (unsigned long) bytes_req, (unsigned long) bytes_alloc,
> - (unsigned long) gfp_flags, node);
> + gfp_flags, node);
All other casts are bogus too.
next prev parent reply other threads:[~2008-11-07 20:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 18:58 Harvey Harrison
2008-11-07 19:20 ` Alexey Dobriyan
2008-11-07 19:22 ` Harvey Harrison
2008-11-07 19:38 ` Mathieu Desnoyers
2008-11-07 19:50 ` Harvey Harrison
2008-11-07 20:41 ` Alexey Dobriyan [this message]
2008-11-07 22:50 ` Eduard - Gabriel Munteanu
2008-11-07 23:08 ` Mathieu Desnoyers
2008-11-07 23:25 ` Alexey Dobriyan
2008-11-07 23:05 ` Eduard - Gabriel Munteanu
2008-11-07 23:06 ` Eduard - Gabriel Munteanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107204114.GA4150@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=eduard.munteanu@linux360.ro \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®