mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: shaohua.li@intel.com, gregkh@suse.de, len.brown@intel.com,
	linux-kernel@vger.kernel.org
Cc: <stable@kernel.org>, <stable-commits@vger.kernel.org>
Subject: patch acpi-dock-avoid-check-_sta-method.patch added to 2.6.25-stable tree
Date: Fri, 07 Nov 2008 14:19:53 -0800	[thread overview]
Message-ID: <20081107223313.81FA048D65@coco.kroah.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0811061417380.3106@localhost.localdomain>


This is a note to let you know that we have just queued up the patch titled

    Subject: ACPI: dock: avoid check _STA method

to the 2.6.25-stable tree.  Its filename is

    acpi-dock-avoid-check-_sta-method.patch

A git repo of this tree can be found at 
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary


>From lenb@kernel.org  Fri Nov  7 14:08:55 2008
From: Shaohua Li <shaohua.li@intel.com>
Date: Thu, 06 Nov 2008 14:18:55 -0500 (EST)
Subject: ACPI: dock: avoid check _STA method
To: stable@kernel.org
Cc: linux-acpi@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Shaohua Li <shaohua.li@intel.com>
Message-ID: <alpine.LFD.2.00.0811061417380.3106@localhost.localdomain>

From: Shaohua Li <shaohua.li@intel.com>

commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db upstream.

ACPI: dock: avoid check _STA method

In some BIOSes, every _STA method call will send a notification again,
this cause freeze. And in some BIOSes, it appears _STA should be called
after _DCK. This tries to avoid calls _STA, and still keep the device
present check.

http://bugzilla.kernel.org/show_bug.cgi?id=10431

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/acpi/dock.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -599,14 +599,17 @@ static int handle_eject_request(struct d
 static void dock_notify(acpi_handle handle, u32 event, void *data)
 {
 	struct dock_station *ds = data;
+	struct acpi_device *tmp;
 
 	switch (event) {
 	case ACPI_NOTIFY_BUS_CHECK:
-		if (!dock_in_progress(ds) && dock_present(ds)) {
+		if (!dock_in_progress(ds) && acpi_bus_get_device(ds->handle,
+		   &tmp)) {
 			begin_dock(ds);
 			dock(ds);
 			if (!dock_present(ds)) {
 				printk(KERN_ERR PREFIX "Unable to dock!\n");
+				complete_dock(ds);
 				break;
 			}
 			atomic_notifier_call_chain(&dock_notifier_list,


Patches currently in stable-queue which might be from shaohua.li@intel.com are

queue-2.6.25/acpi-dock-avoid-check-_sta-method.patch

      parent reply	other threads:[~2008-11-07 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 19:18 [PATCH 2.6.25,26.stable] ACPI: dock: avoid check _STA method Len Brown
2008-11-07 22:11 ` patch acpi-dock-avoid-check-_sta-method.patch added to 2.6.26-stable tree gregkh
2008-11-07 22:19 ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081107223313.81FA048D65@coco.kroah.org \
    --to=gregkh@suse.de \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®