From: Glauber Costa <glommer@redhat.com>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH 0/4] Fix vmalloc regression
Date: Sat, 8 Nov 2008 00:13:15 -0200 [thread overview]
Message-ID: <20081108021315.GB21674@poweredge.glommer> (raw)
In-Reply-To: <20081108005832.GA2068@wotan.suse.de>
On Sat, Nov 08, 2008 at 01:58:32AM +0100, Nick Piggin wrote:
> On Fri, Nov 07, 2008 at 08:35:50PM -0200, Glauber Costa wrote:
> > Nick,
> >
> > This is the whole set of patches I was talking about.
> > Patch 3 is the one that in fact fixes the problem
> > Patches 1 and 2 are debugging aids I made use of, and could be possibly
> > useful to others
> > Patch 4 removes guard pages entirely for non-debug kernels, as we have already
> > previously discussed.
> >
> > Hope it's all fine.
>
> OK, these all look good, but I may only push 3/4 for Linus in this round,
> along with some of the changes from my patch that you tested as well.
Makes total sense.
>
> With the DEBUG_PAGEALLOC case, I have been thinking that we perhaps should
> turn off the lazy unmapping optimisation as well, so it catches use
> after free similarly to the page allocator... but probably it is a good
> idea at least to avoid the double-guard page for 2.6.28?
Makes sense. Maybe poisoning after free would also be useful?
next prev parent reply other threads:[~2008-11-08 2:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 22:35 Glauber Costa
2008-11-07 21:56 ` walt
2008-11-07 22:35 ` [PATCH 1/4] don't call __vmalloc from other vmap internal functions Glauber Costa
2008-11-07 22:35 ` [PATCH 2/4] show size of failing allocation Glauber Costa
2008-11-07 22:35 ` [PATCH 3/4] restart search at beggining of vmalloc address Glauber Costa
2008-11-07 22:35 ` [PATCH 4/4] Do not use guard pages in non-debug kernels Glauber Costa
2008-11-08 0:58 ` [PATCH 0/4] Fix vmalloc regression Nick Piggin
2008-11-08 2:13 ` Glauber Costa [this message]
2008-11-08 2:54 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108021315.GB21674@poweredge.glommer \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®