From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 04/10] ftrace: irqsoff tracer incorrect reset
Date: Fri, 07 Nov 2008 22:46:09 -0500 [thread overview]
Message-ID: <20081108034749.340030047@goodmis.org> (raw)
In-Reply-To: <20081108034605.289816911@goodmis.org>
[-- Attachment #1: 0004-ftrace-irqsoff-tracer-incorrect-reset.patch --]
[-- Type: text/plain, Size: 1134 bytes --]
Impact: fix to irqsoff tracer output
In converting to the new start / stop ftrace handling, the irqsoff
tracer start called the irqsoff reset function. irqsoff tracer is
not the same as the other traces, and it resets the buffers while
searching for the longest latency.
The reset that the irqsoff stop method calls disables the function
tracing. That means that, by starting the tracer, the function
tracer is disabled incorrectly.
This patch simply removes the call to reset which keeps the function
tracing enabled. Reset is not needed for the irqsoff stop method.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace_irqsoff.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
index a87a20f..3509086 100644
--- a/kernel/trace/trace_irqsoff.c
+++ b/kernel/trace/trace_irqsoff.c
@@ -404,7 +404,6 @@ static void irqsoff_tracer_ctrl_update(struct trace_array *tr)
static void irqsoff_tracer_start(struct trace_array *tr)
{
- irqsoff_tracer_reset(tr);
tracer_enabled = 1;
save_tracer_enabled = 1;
}
--
1.5.6.5
--
next prev parent reply other threads:[~2008-11-08 3:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 3:46 [PATCH 00/10] ftrace: various updates Steven Rostedt
2008-11-08 3:46 ` [PATCH 01/10] ftrace: fix set_ftrace_filter Steven Rostedt
2008-11-08 3:46 ` [PATCH 02/10] ftrace: fix boot trace sched startup Steven Rostedt
2008-11-08 4:12 ` Frédéric Weisbecker
2008-11-08 12:17 ` Steven Rostedt
2008-11-08 3:46 ` [PATCH 03/10] ftrace: fix sched_switch API Steven Rostedt
2008-11-08 4:20 ` Frédéric Weisbecker
2008-11-08 3:46 ` Steven Rostedt [this message]
2008-11-08 3:46 ` [PATCH 05/10] ftrace: enable trace_printk by default Steven Rostedt
2008-11-08 3:46 ` [PATCH 06/10] ftrace: remove ctrl_update method Steven Rostedt
2008-11-08 3:46 ` [PATCH 07/10] ftrace: remove trace array ctrl Steven Rostedt
2008-11-08 3:46 ` [PATCH 08/10] ftrace: Align __mcount_loc sections Steven Rostedt
2008-11-08 3:55 ` Steven Rostedt
2008-11-08 3:46 ` [PATCH 09/10] ftrace: force pass of preemptoff selftest Steven Rostedt
2008-11-08 3:46 ` [PATCH 10/10] ftrace: display start of CPU buffer in trace output Steven Rostedt
2008-11-08 8:42 ` [PATCH 00/10] ftrace: various updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108034749.340030047@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®