From: Arjan van de Ven <arjan@infradead.org>
To: Julia Lawall <julia@diku.dk>
Cc: mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org,
video4linux-list@redhat.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/8] drivers/media: use ARRAY_SIZE
Date: Sun, 9 Nov 2008 09:14:27 -0800 [thread overview]
Message-ID: <20081109091427.1d6bdfcd@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0811091754410.32509@ask.diku.dk>
On Sun, 9 Nov 2008 17:55:03 +0100 (CET)
Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> ARRAY_SIZE is more concise to use when the size of an array is
> divided by the size of its type or the size of its first element.
Hi,
looking at your patch, I don't think I agree it's just blindly the
right thing to do.
> - *count = sizeof(RegAddr) / sizeof(u8);
> + *count = ARRAY_SIZE(RegAddr);
really. ARRAY_SIZE doesn't appear to be an improvement here..
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-11-09 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-09 16:55 Julia Lawall
2008-11-09 17:14 ` Arjan van de Ven [this message]
2008-11-12 23:17 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081109091427.1d6bdfcd@infradead.org \
--to=arjan@infradead.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®