From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>,
a.zummo@towertech.it, david-b@pacbell.net,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing
Date: Wed, 12 Nov 2008 11:21:06 +0100 [thread overview]
Message-ID: <20081112112106.5b5062f4@i1501.lan.towertech.it> (raw)
In-Reply-To: <20081111161728.8a0d73f1.akpm@linux-foundation.org>
On Tue, 11 Nov 2008 16:17:28 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> > rtc-sh.c is using platform_get_irq, but was storing a result into an
> > unsigned type, then was checking for < 0. This is fixed now.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> Do we see any reason why this should be pushed into 2.6.28?
We are not in hurry I'd say. Also irq is valid on some platforms,
so the check only makes sense for drivers whose platforms
do not use it.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
prev parent reply other threads:[~2008-11-12 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 17:41 Anton Vorontsov
2008-11-10 22:34 ` David Brownell
2008-11-12 0:17 ` Andrew Morton
2008-11-12 10:21 ` Alessandro Zummo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112112106.5b5062f4@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome