From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753317AbYKLOsL@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753317AbYKLOsL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 12 Nov 2008 09:48:11 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752311AbYKLOr4
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 12 Nov 2008 09:47:56 -0500
Received: from cmpxchg.org ([85.214.51.133]:36169 "EHLO cmpxchg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752075AbYKLOr4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 12 Nov 2008 09:47:56 -0500
Date: Wed, 12 Nov 2008 15:47:09 +0100
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] [4/4] SCHED: Use a lookup array in sd_level_to_string
Message-ID: <20081112144709.GB2672@cmpxchg.org>
References: <20081112145.328971960@firstfloor.org> <20081112124512.6EEF63E6610@basil.firstfloor.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081112124512.6EEF63E6610@basil.firstfloor.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 12, 2008 at 01:45:12PM +0100, Andi Kleen wrote:
> 
> Generates better/shorter code. Doesn't matter much because it's only
> a SCHED_DEBUG function. 
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> ---
>  kernel/sched.c |   29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> Index: linux-2.6.28-rc4-test/kernel/sched.c
> ===================================================================
> --- linux-2.6.28-rc4-test.orig/kernel/sched.c	2008-11-12 12:36:23.000000000 +0100
> +++ linux-2.6.28-rc4-test/kernel/sched.c	2008-11-12 12:43:58.000000000 +0100
> @@ -6629,24 +6629,17 @@
>  
>  static inline const char *sd_level_to_string(enum sched_domain_level lvl)
>  {
> -	switch (lvl) {
> -	case SD_LV_NONE:
> -			return "NONE";
> -	case SD_LV_SIBLING:
> -			return "SIBLING";
> -	case SD_LV_MC:
> -			return "MC";
> -	case SD_LV_CPU:
> -			return "CPU";
> -	case SD_LV_NODE:
> -			return "NODE";
> -	case SD_LV_ALLNODES:
> -			return "ALLNODES";
> -	case SD_LV_MAX:
> -			return "MAX";
> -
> -	}
> -	return "MAX";
> +	static const char *lva[] = {
> +#define T(x) [SD_LV_ ## x ] = #T

Shouldn't                         ^ that be x?

	Hannes