mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Warne <nick@ukfsn.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware
Date: Sat, 15 Nov 2008 12:32:10 +0000	[thread overview]
Message-ID: <20081115123210.60500f29@palantir.linicks.net> (raw)
In-Reply-To: <20081112165650.GA15594@srcf.ucam.org>

On Wed, 12 Nov 2008 16:56:50 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:

> Does this work?
> 
> diff --git a/drivers/input/keyboard/atkbd.c
> b/drivers/input/keyboard/atkbd.c index 22016ca..15479ef 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1460,6 +1460,15 @@ static struct dmi_system_id
> atkbd_dmi_quirk_table[] __initdata = { .driver_data =
> atkbd_dell_laptop_keymap_fixup, },
>  	{
> +		.ident = "Dell Laptop",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer
> Corporation"),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /*
> Portable */
> +		},
> +		.callback = atkbd_setup_fixup,
> +		.driver_data = atkbd_dell_laptop_keymap_fixup,
> +	},
> +	{
>  		.ident = "HP 2133",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 

OK, as discussed, I cannot test this, but my research leads to this to
be correct:

http://ubuntuforums.org/showthread.php?t=978973

Dell use vendor ID s either 'Dell Inc.' or 'Dell Computer Corporation'
exclusively.

So I think this can be officially submitted.

Nick

-- 
Free Software Foundation Associate Member 5508

  parent reply	other threads:[~2008-11-15 12:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11  7:47 Nick Warne
2008-11-12 13:14 ` Nick Warne
2008-11-12 16:45   ` Andreas Mohr
2008-11-12 16:56   ` Matthew Garrett
2008-11-12 17:24     ` Nick Warne
2008-11-12 17:27       ` Matthew Garrett
2008-11-12 17:40         ` Nick Warne
2008-11-12 17:41           ` Matthew Garrett
2008-11-15 12:32     ` Nick Warne [this message]
2008-12-29 11:36     ` Nick Warne
2008-12-29 14:29       ` [PATCH] Input: atkbd - broaden the Dell DMI signatures Matthew Garrett
2008-12-30  4:15         ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2008-08-14  3:32 [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware Matthew Garrett
2008-08-15 19:04 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081115123210.60500f29@palantir.linicks.net \
    --to=nick@ukfsn.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®