From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756545AbYKONio (ORCPT ); Sat, 15 Nov 2008 08:38:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755400AbYKONiH (ORCPT ); Sat, 15 Nov 2008 08:38:07 -0500 Received: from one.firstfloor.org ([213.235.205.2]:58883 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755419AbYKONiF (ORCPT ); Sat, 15 Nov 2008 08:38:05 -0500 From: Andi Kleen References: <20081115237.317953894@firstfloor.org> In-Reply-To: <20081115237.317953894@firstfloor.org> To: mingo@elte.hu, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH REPOST] [3/3] SCHED: don't inline idle_balance into schedule() Message-Id: <20081115133802.5DA4C3E661B@basil.firstfloor.org> Date: Sat, 15 Nov 2008 14:38:02 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function is not called under load, so it makes sense to out of line it to get better register allocation in schedule() and make the assembler easier to read. Signed-off-by: Andi Kleen --- kernel/sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.28-rc4-test/kernel/sched.c =================================================================== --- linux-2.6.28-rc4-test.orig/kernel/sched.c 2008-11-12 12:52:52.000000000 +0100 +++ linux-2.6.28-rc4-test/kernel/sched.c 2008-11-12 13:07:53.000000000 +0100 @@ -3696,7 +3696,7 @@ * idle_balance is called by schedule() if this_cpu is about to become * idle. Attempts to pull tasks from other CPUs. */ -static void idle_balance(int this_cpu, struct rq *this_rq) +static void noinline idle_balance(int this_cpu, struct rq *this_rq) { struct sched_domain *sd; int pulled_task = -1;