From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] stop_machine: fix race with return value (fixes Bug #11989)
Date: Mon, 17 Nov 2008 10:46:18 +0100 [thread overview]
Message-ID: <20081117094618.GA4296@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <200811170822.18880.rusty@rustcorp.com.au>
On Mon, Nov 17, 2008 at 08:22:18AM +1030, Rusty Russell wrote:
> Bug #11989: Suspend failure on NForce4-based boards due to chanes in stop_machine
>
> We should not access active.fnret outside the lock; in theory the next
> stop_machine could overwrite it.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Tested-by: "Rafael J. Wysocki" <rjw@sisk.pl>
> ---
> kernel/stop_machine.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thank you, Rusty, for finding and fixing this one as well!
prev parent reply other threads:[~2008-11-17 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 21:52 Rusty Russell
2008-11-17 9:46 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117094618.GA4296@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®