From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2
Date: Mon, 17 Nov 2008 20:11:57 +0300 [thread overview]
Message-ID: <20081117171157.GB7326@localhost> (raw)
In-Reply-To: <20081117165224.GH12081@elte.hu>
[Ingo Molnar - Mon, Nov 17, 2008 at 05:52:24PM +0100]
|
| * Yinghai Lu <yinghai@kernel.org> wrote:
|
| > Impact: fix wakeup path with numaq and es7000
|
| applied to tip/x86/quirks, thanks Yinghai!
|
| A couple of comments:
|
| > +static inline void inquire_remote_apic(int apicid)
| > +{
| > + if (apic_verbosity >= APIC_DEBUG)
| > + __inquire_remote_apic(apicid);
| > +}
|
Btw, Ingo, Yinghai,
it's a bit weird but I found that we use apic_verbosity
here to _do_ something (ie touching circuit) but on any
other cases apic_verbosity is just a additional logging
filter so -- what the initial apic_verbosity purpose was?
If it's just a logging filter (to which I'm more biased)
this case is plain wrong. But if apic_verbosity is not
like this -- then it's fine. Since I was not initial author
of the code -- I'm asking you :)
- Cyrill -
next prev parent reply other threads:[~2008-11-17 17:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 8:47 [PATCH] x86: fix wakeup_cpu with numaq/es7000 Yinghai Lu
2008-11-16 11:12 ` [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 Yinghai Lu
2008-11-17 16:52 ` Ingo Molnar
2008-11-17 17:11 ` Cyrill Gorcunov [this message]
2008-11-17 17:35 ` Ingo Molnar
2008-11-17 17:52 ` Cyrill Gorcunov
2008-11-17 17:37 ` Ingo Molnar
2008-11-17 17:38 ` Ingo Molnar
2008-11-17 18:18 ` Yinghai Lu
2008-11-17 17:38 ` Ingo Molnar
2008-11-17 21:06 ` Yinghai Lu
2008-11-17 23:19 ` Yinghai Lu
2008-11-17 23:28 ` Ingo Molnar
2008-11-18 2:49 ` Yinghai Lu
2008-11-18 2:51 ` Yinghai Lu
2008-11-18 7:43 ` Ingo Molnar
2008-11-18 16:13 ` [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 - fix v2 Yinghai Lu
2008-11-18 16:14 ` [PATCH] x86: use update_genapic to get rid of ES7000_CLUSTERED_APIC v2 Yinghai Lu
2008-11-18 21:14 ` [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 - fix v2 Ingo Molnar
2008-11-20 4:50 ` Yinghai Lu
2008-11-20 4:00 ` [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 Hiroshi Shimamoto
2008-11-20 9:46 ` Ingo Molnar
2008-11-20 18:15 ` Hiroshi Shimamoto
2008-11-17 17:54 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117171157.GB7326@localhost \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome