From: Yi Zou <yi.zou@intel.com>
To: davem@davemloft.net
Cc: jeff@garzik.org, linux-netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] net: reclaim 8 upper bits of the netdev->features from GSO
Date: Mon, 17 Nov 2008 10:30:39 -0800 [thread overview]
Message-ID: <20081117183039.15776.61222.stgit@zychongqing.jf.intel.com> (raw)
In-Reply-To: <20081117182659.15776.58181.stgit@zychongqing.jf.intel.com>
From: Chris Leech <christopher.leech@intel.com>
Signed-off-by: Chris Leech <christopher.leech@intel.com>
Signed-off-by: Yi Zou <yi.zou@intel.com>
---
drivers/net/xen-netfront.c | 2 +-
include/linux/netdevice.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 4b21bcf..a2bbdaa 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1504,7 +1504,7 @@ static int xennet_set_tso(struct net_device *dev, u32 data)
static void xennet_set_features(struct net_device *dev)
{
/* Turn off all GSO bits except ROBUST. */
- dev->features &= (1 << NETIF_F_GSO_SHIFT) - 1;
+ dev->features &= ~NETIF_F_GSO_MASK;
dev->features |= NETIF_F_GSO_ROBUST;
xennet_set_sg(dev, 0);
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 12d7f44..423c7bc 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -525,7 +525,7 @@ struct net_device
/* Segmentation offload features */
#define NETIF_F_GSO_SHIFT 16
-#define NETIF_F_GSO_MASK 0xffff0000
+#define NETIF_F_GSO_MASK 0x00ff0000
#define NETIF_F_TSO (SKB_GSO_TCPV4 << NETIF_F_GSO_SHIFT)
#define NETIF_F_UFO (SKB_GSO_UDP << NETIF_F_GSO_SHIFT)
#define NETIF_F_GSO_ROBUST (SKB_GSO_DODGY << NETIF_F_GSO_SHIFT)
next prev parent reply other threads:[~2008-11-17 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 18:30 [PATCH 0/3] net: New flags for Fibre Channel over Ethernet (FCoE) (Resubmit) Yi Zou
2008-11-17 18:30 ` [PATCH 1/3] net: add ETH_P_FCOE for Fibre Channel over Ethernet (FCoE) Yi Zou
2008-11-17 18:30 ` Yi Zou [this message]
2008-11-17 18:30 ` [PATCH 3/3] net: define feature flags for FCoE offloads Yi Zou
2008-11-19 23:47 ` David Miller
2008-11-20 0:02 ` Zou, Yi
2008-11-20 1:14 ` David Miller
2008-11-20 1:18 ` David Miller
2008-11-20 8:01 ` Zou, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117183039.15776.61222.stgit@zychongqing.jf.intel.com \
--to=yi.zou@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®