From: Michael Halcrow <mhalcrow@us.ibm.com>
To: Leon Woestenberg <leon.woestenberg@gmail.com>
Cc: linux-kernel@vger.kernel.org, pjssilva@ime.usp.br,
akpm@linux-foundation.org, dustin.kirkland@gmail.com,
sandeen@redhat.com
Subject: Re: [PATCH] eCryptfs: Allocate up to two scatterlists for crypto ops on keys
Date: Tue, 18 Nov 2008 16:31:00 -0600 [thread overview]
Message-ID: <20081118223100.GC6581@halcrowt61p.austin.ibm.com> (raw)
In-Reply-To: <c384c5ea0811140849x9f6df35kaa36ff7ce2192ddf@mail.gmail.com>
On Fri, Nov 14, 2008 at 05:49:58PM +0100, Leon Woestenberg wrote:
> Hello,
>
> On Fri, Nov 14, 2008 at 5:40 PM, Michael Halcrow <mhalcrow@us.ibm.com> wrote:
> >
> > - sg_init_table(&dst_sg, 1);
> > - sg_init_table(&src_sg, 1);
>
> Why did you remove the inits?
This initialization is done in virt_to_scatterlist() and is thus
redundant for this function.
> With self-checking enabled in the kernel, sg accessor functions will
> check on proper initialization and BUGON().
>
> It might be your use-case would not hit this, as it seems not to use
> sg_ macro's much.
>
> Regards,
next prev parent reply other threads:[~2008-11-18 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 16:40 Michael Halcrow
2008-11-14 16:49 ` Leon Woestenberg
2008-11-18 22:31 ` Michael Halcrow [this message]
2008-11-14 16:58 ` [stable] " Greg KH
2008-11-17 20:27 ` Michael Halcrow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118223100.GC6581@halcrowt61p.austin.ibm.com \
--to=mhalcrow@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dustin.kirkland@gmail.com \
--cc=leon.woestenberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjssilva@ime.usp.br \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®