Re: [PATCH 0/3] ftrace updates to tip/core/urgent

[Ingo Molnar <mingo@elte.hu>]

* Steven Rostedt <rostedt@goodmis.org> wrote:

> Ingo,
> 
> I ported the following patches to tip/core/urgent since they are 
> candidates for 2.6.28.
> 
> The first two are trivial, short, and should not be an issue. The 
> first two handle the printing of the set_ftrace_filter file 
> correctly.
> 
> The third is a bigger patch "108 lines changed" and is actually a 
> clean up and fix.  The difference is that the current logic to 
> determine if a function should be enabled or not is incorrect. With 
> different combinations of using set_ftrace_filter and 
> set_ftrace_notrace, incorrect functions may be traced, or not 
> traced.
> 
> But this bug that the patch fixes is not a critical bug. It should 
> not cause any stability problems with the kernel. The bug will only 
> produce undesirable traces.
> 
> But on the other hand, adding that last patch should not cause any 
> stability issues as well. And it makes the complex function cleaner 
> and more importantly, by coupling the ENABLED flag of the record 
> with the enabling (or disabling) of the tracing of the function the 
> record represents, makes the code more robust.

ok, agreed.

> The following patches are in:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> 
>       branch: tip/urgent
> 
> 
> Steven Rostedt (3):
>       ftrace: fix set_ftrace_filter
>       ftrace: make filtered functions effective on setting
>       ftrace: fix dyn ftrace filter selection
> 
> ----
>  kernel/trace/ftrace.c |  113 +++++++++++++++++++++++-------------------------
>  1 files changed, 54 insertions(+), 59 deletions(-)

pulled into tip/tracing/urgent, thanks Steve!

	Ingo