From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Emelyanov <xemul@openvz.org>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] simplify sig_ignored() pathes
Date: Wed, 19 Nov 2008 10:53:29 -0800 (PST) [thread overview]
Message-ID: <20081119185329.1FEC01544EB@magilla.localdomain> (raw)
In-Reply-To: Oleg Nesterov's message of Tuesday, 18 November 2008 18:59:05 +0100 <20081118175905.GA17142@redhat.com>
> The code which checks for ignored signals is a bit overcomplicated
> because tracehook_consider_ignored_signal() wants the "handler" arg.
> Can't we kill it? It is not used even with utrace, and even if it will
> be used later it is OK to read ->sighand again in the slow path.
Yeah, it's fine to kill the arg. For consistency, change
tracehook_consider_fatal_signal to match. They are specified as called
with the siglock held, so it will indeed be easy and safe to check
->sighand if tracing code wants to distinguish the cases in the future.
Thanks,
Roland
prev parent reply other threads:[~2008-11-19 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 17:59 Oleg Nesterov
2008-11-19 18:53 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119185329.1FEC01544EB@magilla.localdomain \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=serue@us.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®