Re: [PATCH] [WATCHDOG] [hpwdt] Set the mapped BIOS address space as executable

[Bernhard Walle <bwalle@suse.de>]

* Wim Van Sebroeck [2008-11-20 00:00]:
>
> Hi All,
> 
> > * Andrew Morton [2008-11-19 09:30]:
> > > > 
> > > 
> > > (top-posting repaired.  Please don't top-post!)
> > > 
> > > I haven't seen any patch which alters hpwdt_pretimeout() and there is
> > > no such patch in linux-next.  Perhaps it got lost?
> 
> This was the patch (see below). It's in the linux-2.6-watchdog-next tree now,
> so it should go into the linux-next tree soon.
> 
> The other patch is in the linux-2.6-watchdog-next tree also.

Wasn't the conclusion that NOTIFY_OK always works and we should not
rely on that 'allow_kdump' option?


Regards,
Bernhard


>  
>  static void __iomem *pci_mem_addr;		/* the PCI-memory address */
>  static unsigned long __iomem *hpwdt_timer_reg;
> @@ -485,7 +485,11 @@ static int hpwdt_pretimeout(struct notifier_block *nb, unsigned long ulReason,
>  			"Management Log for details.\n");
>  	}
>  
> -	return NOTIFY_STOP;
> +	/*
> +	 * for kdump, we must return NOTIFY_OK here to execute the
> +	 * crash_nmi_callback afterwards, see arch/x86/kernel/crash.c
> +	 */
> +	return allow_kdump ? NOTIFY_OK : NOTIFY_STOP;
>  }
>  
>  /*