mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@infradead.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 1/4] trace: remove extra assign in branch check
Date: Fri, 21 Nov 2008 02:12:14 -0500	[thread overview]
Message-ID: <20081121071327.769783077@goodmis.org> (raw)
In-Reply-To: <20081121071213.365288293@goodmis.org>

[-- Attachment #1: 0001-trace-remove-extra-assign-in-branch-check.patch --]
[-- Type: text/plain, Size: 1138 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

Impact: clean up of branch check

The unlikely/likely profiler does an extra assign of the f.line.
This is not needed since it is already calculated at compile time.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
 include/linux/compiler.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index c7d804a..c25e525 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -87,7 +87,6 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
 				.file = __FILE__,			\
 				.line = __LINE__,			\
 			};						\
-			______f.line = __LINE__;			\
 			______r = likely_notrace(x);			\
 			ftrace_likely_update(&______f, ______r, 1);	\
 			______r;					\
@@ -102,7 +101,6 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
 				.file = __FILE__,			\
 				.line = __LINE__,			\
 			};						\
-			______f.line = __LINE__;			\
 			______r = unlikely_notrace(x);			\
 			ftrace_likely_update(&______f, ______r, 0);	\
 			______r;					\
-- 
1.5.6.5

-- 

  reply	other threads:[~2008-11-21  7:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21  7:12 [PATCH 0/4] trace: profiling branches Steven Rostedt
2008-11-21  7:12 ` Steven Rostedt [this message]
2008-11-21  7:12 ` [PATCH 2/4] trace: consolidate unlikely and likely profiler Steven Rostedt
2008-11-21  7:12 ` [PATCH 3/4] trace: branch profiling should not print percent without data Steven Rostedt
2008-11-21  7:12 ` [PATCH 4/4] trace: profile all if conditionals Steven Rostedt
2008-11-21 23:20   ` Andrew Morton
2008-11-21 23:33     ` Steven Rostedt
2008-11-23 12:37       ` Ingo Molnar
2008-11-23 15:48   ` Ingo Molnar
2008-11-23 16:07     ` [PATCH] net/wireless/reg.c: fix Ingo Molnar
2008-11-23 19:43   ` [PATCH 4/4] trace: profile all if conditionals Andi Kleen
2008-11-23 19:56     ` Steven Rostedt
2008-11-23 20:24       ` Andi Kleen
2008-11-23 20:32         ` Steven Rostedt
2008-11-23 20:51           ` Andi Kleen
2008-11-23 21:38       ` Ingo Molnar
2008-11-30 10:58 ` [PATCH 0/4] trace: profiling branches Daniel Walker
2008-11-30 15:19   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081121071327.769783077@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome