From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips <linux-mips@linux-mips.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Make BUG() __noreturn.
Date: Fri, 21 Nov 2008 10:00:35 +0000 [thread overview]
Message-ID: <20081121100035.3f5a640b@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <49260E4C.8080500@caviumnetworks.com>
On Thu, 20 Nov 2008 17:26:36 -0800
David Daney <ddaney@caviumnetworks.com> wrote:
> MIPS: Make BUG() __noreturn.
>
> Often we do things like put BUG() in the default clause of a case
> statement. Since it was not declared __noreturn, this could sometimes
> lead to bogus compiler warnings that variables were used
> uninitialized.
>
> There is a small problem in that we have to put a magic while(1); loop to
> fool GCC into really thinking it is noreturn.
That sounds like your __noreturn macro is wrong.
Try using __attribute__ ((__noreturn__))
if that works then fix up the __noreturn definitions for the MIPS and gcc
you have.
next prev parent reply other threads:[~2008-11-21 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 1:26 David Daney
2008-11-21 10:00 ` Alan Cox [this message]
2008-11-21 10:27 ` Geert Uytterhoeven
2008-11-21 11:14 ` Maciej W. Rozycki
2008-11-21 12:58 ` Andreas Schwab
2008-11-21 16:40 ` David Daney
2008-11-21 18:46 ` Geert Uytterhoeven
2008-11-21 22:16 ` Ralf Baechle
2008-11-24 19:04 ` Maciej W. Rozycki
2008-11-21 23:00 ` Andrew Morton
2008-11-21 23:48 ` David Daney
2008-11-23 9:58 ` Ingo Molnar
2008-11-24 9:20 ` Ralf Baechle
2008-11-25 0:16 ` Jeremy Fitzhardinge
2008-11-22 9:39 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121100035.3f5a640b@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®