From: Brad Boyer <flar@allandria.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Davide Libenzi <davidel@xmailserver.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew@wil.cx>,
Miklos Szeredi <miklos@szeredi.hu>,
arjan@linux.intel.com,
Linus Torvalds <torvalds@linux-foundation.org>,
hch@infradead.org, Ingo Molnar <mingo@elte.hu>,
rminnich@sandia.gov, ericvh@gmail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: poll: allow f_op->poll to sleep, take #3
Date: Sat, 22 Nov 2008 19:34:57 -0800 [thread overview]
Message-ID: <20081123033457.GA1912@cynthia.pants.nu> (raw)
In-Reply-To: <4928C891.80405@gmail.com>
On Sun, Nov 23, 2008 at 12:05:53PM +0900, Tejun Heo wrote:
> I thought try_to_wake_up() was made static to avoid abuse but then again
> creating dummy waitqueue is an obvious abuse of waitqueue. What do
> other people think? I'll be happy to use try_to_wake_up() directly.
Do you need all the extra arguments? The function wake_up_process()
is already a wrapper around try_to_wake_up() and is exported, but
it doesn't have any arguments other than the task_struct and uses
defaults for the other arguments. I'm not sure if anything in your
code would break by ignoring the other possible values instead of
passing them along from the arguments into the caller.
Brad Boyer
flar@allandria.com
next prev parent reply other threads:[~2008-11-23 3:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 8:58 [PATCH fwd] poll: allow f_op->poll to sleep Miklos Szeredi
2008-11-22 9:27 ` Andrew Morton
2008-11-22 12:39 ` Matthew Wilcox
2008-11-22 12:43 ` Tejun Heo
2008-11-22 18:53 ` Andrew Morton
2008-11-23 1:26 ` poll: allow f_op->poll to sleep, take #3 Tejun Heo
2008-11-23 2:35 ` Davide Libenzi
2008-11-23 3:05 ` Tejun Heo
2008-11-23 3:34 ` Brad Boyer [this message]
2008-11-23 3:48 ` Tejun Heo
2008-11-23 8:59 ` Ingo Molnar
2008-11-23 9:14 ` Tejun Heo
2008-11-23 9:34 ` Ingo Molnar
2008-11-23 9:43 ` Tejun Heo
2008-11-23 9:45 ` Ingo Molnar
2008-11-24 4:29 ` Tejun Heo
2008-11-24 4:57 ` Davide Libenzi
2008-11-24 5:05 ` Davide Libenzi
2008-11-24 6:09 ` [PATCH] poll: allow f_op->poll to sleep, take #4 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123033457.GA1912@cynthia.pants.nu \
--to=flar@allandria.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=davidel@xmailserver.org \
--cc=ericvh@gmail.com \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=miklos@szeredi.hu \
--cc=mingo@elte.hu \
--cc=rminnich@sandia.gov \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®