From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Ingo Molnar <mingo@elte.hu>, Dipankar Sarma <dipankar@in.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Vatsa <vatsa@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
David Collier-Brown <davecb@sun.com>,
Tim Connors <tconnors@astro.swin.edu.au>,
Max Krasnyansky <maxk@qualcomm.com>,
Gregory Haskins <gregory.haskins@gmail.com>
Subject: Re: [RFC PATCH v4 3/7] sched: nominate preferred wakeup cpu
Date: Mon, 24 Nov 2008 11:44:31 +0530 [thread overview]
Message-ID: <20081124061431.GB4457@dirshya.in.ibm.com> (raw)
In-Reply-To: <1227405838.7685.20000.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> [2008-11-23 03:03:58]:
> On Fri, 2008-11-21 at 14:01 +0530, Vaidyanathan Srinivasan wrote:
> > When the system utilisation is low and more cpus are idle,
> > then the process waking up from sleep should prefer to
> > wakeup an idle cpu from semi-idle cpu package (multi core
> > package) rather than a completely idle cpu package which
> > would waste power.
> >
> > Use the sched_mc balance logic in find_busiest_group() to
> > nominate a preferred wakeup cpu.
> >
> > This info can be sored in appropriate sched_domain, but
> > updating this info in all copies of sched_domain is not
> > practical. Hence this information is stored in root_domain
> > struct which is one copy per partitioned sched domain.
> > The root_domain can be accessed from each cpu's runqueue
> > and there is one copy per partitioned sched domain.
> >
> > Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
> > ---
> >
> > kernel/sched.c | 15 +++++++++++++++
> > 1 files changed, 15 insertions(+), 0 deletions(-)
> >
> > diff --git a/kernel/sched.c b/kernel/sched.c
> > index 79b71f3..d28cd98 100644
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -493,6 +493,17 @@ struct root_domain {
> > #ifdef CONFIG_SMP
> > struct cpupri cpupri;
> > #endif
> > +#if defined(CONFIG_SCHED_MC) || defined(CONFIG_SCHED_SMT)
> > +
> > + /*
> > + * Preferred wake up cpu nominated by sched_mc balance that will be
> > + * used when most cpus are idle in the system indicating overall very
> > + * low system utilisation. Triggered at POWERSAVINGS_BALANCE_WAKEUP(2)
> > + */
> > + unsigned int sched_mc_preferred_wakeup_cpu;
> > +
> > +#endif
> > +
> > };
> >
> > /*
>
> Do we really need that extra whitespace?
>
> > @@ -3090,6 +3101,7 @@ static int move_one_task(struct rq *this_rq, int this_cpu, struct rq *busiest,
> > return 0;
> > }
> >
> > +
> > /*
> > * find_busiest_group finds and returns the busiest CPU group within the
> > * domain. It calculates and returns the amount of weighted load which
>
> Ditto?
>
> > @@ -3406,6 +3418,9 @@ out_balanced:
> >
> > if (this == group_leader && group_leader != group_min) {
> > *imbalance = min_load_per_task;
> > + if (sched_mc_power_savings >= POWERSAVINGS_BALANCE_WAKEUP)
> > + cpu_rq(this_cpu)->rd->sched_mc_preferred_wakeup_cpu =
> > + first_cpu(group_leader->cpumask);
>
> While not strictly needed, I prefer braces around multi-line statments.
> It's easier on the eyes.
Hi Peter,
Thanks for the detailed review. I will fix these issues in the next
iteration.
--Vaidy
next prev parent reply other threads:[~2008-11-24 6:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 8:30 [RFC PATCH v4 0/7] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
2008-11-21 8:30 ` [RFC PATCH v4 1/7] sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan
2008-11-21 19:45 ` David Collier-Brown
2008-11-22 18:06 ` Vaidyanathan Srinivasan
2008-11-21 8:31 ` [RFC PATCH v4 2/7] sched: favour lower logical cpu number for sched_mc balance Vaidyanathan Srinivasan
2008-11-21 8:31 ` [RFC PATCH v4 3/7] sched: nominate preferred wakeup cpu Vaidyanathan Srinivasan
2008-11-23 2:03 ` Peter Zijlstra
2008-11-24 6:14 ` Vaidyanathan Srinivasan [this message]
2008-11-21 8:31 ` [RFC PATCH v4 4/7] sched: bias task wakeups to preferred semi-idle packages Vaidyanathan Srinivasan
2008-11-21 8:31 ` [RFC PATCH v4 5/7] sched: activate active load balancing in new idle cpus Vaidyanathan Srinivasan
2008-11-21 8:31 ` [RFC PATCH v4 6/7] sched: re-tune balancing -- revert Vaidyanathan Srinivasan
2008-11-21 8:31 ` [RFC PATCH v4 7/7] sched: fine-tune SD_MC_INIT " Vaidyanathan Srinivasan
2008-11-23 2:09 ` [RFC PATCH v4 0/7] Tunable sched_mc_power_savings=n Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124061431.GB4457@dirshya.in.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=davecb@sun.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=gregory.haskins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tconnors@astro.swin.edu.au \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®