mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <petkovbb@googlemail.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: bzolnier@gmail.com, sshtylyov@ru.mvista.com,
	alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: Is the change to IDE probing really necessary?
Date: Tue, 25 Nov 2008 08:21:56 +0100	[thread overview]
Message-ID: <20081125072156.GA3771@gollum.tnic> (raw)
In-Reply-To: <20081125000102.GC8293@csn.ul.ie>

[.. ]

> > And the probing _is_ done when loaded as a module so the problem is
> > not with the mask - in your case the probing will work just fine as
> > you need ide0 and ide1, AFAICT.
> 
> Out of curiousity, I loaded ide-generic as a module and tried the suggested
> probe_mask. It loads after e100 which is built in and then has a crap attack
> as it tries to register IO regions which are already registered, triggers
> sysfs warnings for creating duplicate files and then continues along to
> a state where networking doesn't work anyway. That suggestion of 0x3f may
> still catch someone.

Yep, the message could be misleading wrt to the probe_mask. Is something
along the lines of

"please adjust the probe_mask module parameter for probing the rest of the
legacy ISA IDE ports"

more informative? Now it implies that the primary/secondary ports are
probed by default.

However, you still have to set it to something > 0x3 if you want to
probe ide[2-5]. Also, there's still the option of CONFIG_BLK_DEV_GENERIC
which adds support for otherwise unsupported IDE PCI controllers.

-- 
Regards/Gruss,
    Boris.

  reply	other threads:[~2008-11-25  7:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 15:56 Mel Gorman
2008-11-24 18:43 ` Mel Gorman
2008-11-24 18:54   ` Alan Cox
2008-11-24 23:09     ` Mel Gorman
2008-11-25  0:03       ` Alan Cox
2008-11-25  0:16         ` Mel Gorman
2008-11-25  0:30           ` Alan Cox
2008-11-25  0:36             ` Mel Gorman
2008-11-24 22:51 ` Borislav Petkov
2008-11-25  0:01   ` Mel Gorman
2008-11-25  7:21     ` Borislav Petkov [this message]
2008-11-25 10:45       ` Mel Gorman
     [not found] <bBM1f-6TS-19@gated-at.bofh.it>
     [not found] ` <bBOFD-1WX-21@gated-at.bofh.it>
     [not found]   ` <bBOYV-2w9-7@gated-at.bofh.it>
     [not found]     ` <bBSST-7ut-11@gated-at.bofh.it>
     [not found]       ` <bBTFg-8vL-15@gated-at.bofh.it>
     [not found]         ` <bBTOS-dn-3@gated-at.bofh.it>
     [not found]           ` <bBU8c-w0-1@gated-at.bofh.it>
2008-11-26 21:48             ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125072156.GA3771@gollum.tnic \
    --to=petkovbb@googlemail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=petkovbb@gmail.com \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®