From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@openedhand.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] power_supply: Add cold to the POWER_SUPPLY_HEALTH report values
Date: Tue, 25 Nov 2008 14:25:12 +0300 [thread overview]
Message-ID: <20081125112512.GA1110@zarina> (raw)
In-Reply-To: <1227194621-16442-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, Nov 20, 2008 at 03:23:40PM +0000, Mark Brown wrote:
> Some systems are able to report problems with batteries being under
> temperature.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Looks good to me.
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
> ---
> drivers/power/power_supply_sysfs.c | 2 +-
> include/linux/power_supply.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 23ae846..ac01e06 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -45,7 +45,7 @@ static ssize_t power_supply_show_property(struct device *dev,
> };
> static char *health_text[] = {
> "Unknown", "Good", "Overheat", "Dead", "Over voltage",
> - "Unspecified failure"
> + "Unspecified failure", "Cold",
> };
> static char *technology_text[] = {
> "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd",
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index f9348cb..8ff25e0 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -45,6 +45,7 @@ enum {
> POWER_SUPPLY_HEALTH_DEAD,
> POWER_SUPPLY_HEALTH_OVERVOLTAGE,
> POWER_SUPPLY_HEALTH_UNSPEC_FAILURE,
> + POWER_SUPPLY_HEALTH_COLD,
> };
>
> enum {
> --
> 1.5.6.5
>
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-11-25 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 15:20 [PATCH 0/2] Add battery health reporting for WM8350 Mark Brown
2008-11-20 15:23 ` [PATCH 1/2] power_supply: Add cold to the POWER_SUPPLY_HEALTH report values Mark Brown
2008-11-20 15:23 ` [PATCH 2/2] power_supply: Add battery health reporting for WM8350 Mark Brown
2008-11-25 11:26 ` Anton Vorontsov
2008-11-25 11:25 ` Anton Vorontsov [this message]
2008-12-01 0:08 ` [PATCH 1/2] power_supply: Add cold to the POWER_SUPPLY_HEALTH report values Samuel Ortiz
2008-11-24 19:27 ` [PATCH 0/2] Add battery health reporting for WM8350 Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125112512.GA1110@zarina \
--to=cbouatmailru@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®