From: Ingo Molnar <mingo@elte.hu>
To: Hannes Eder <hannes@hanneseder.net>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH] x86: microcode: fix sparse warnings
Date: Wed, 26 Nov 2008 08:49:38 +0100 [thread overview]
Message-ID: <20081126074938.GJ26036@elte.hu> (raw)
In-Reply-To: <154e089b0811231149qcb31d00r5b28d55f81b8e6d0@mail.gmail.com>
* Hannes Eder <hannes@hanneseder.net> wrote:
> Impact: make global variables and a function static
>
> Fix following sparse warnings:
>
> arch/x86/kernel/microcode_core.c:102:22: warning: symbol
> 'microcode_ops' was not declared. Should it be static?
> arch/x86/kernel/microcode_core.c:206:24: warning: symbol
> 'microcode_pdev' was not declared. Should it be static?
> arch/x86/kernel/microcode_core.c:322:6: warning: symbol
> 'microcode_update_cpu' was not declared. Should it be static?
> arch/x86/kernel/microcode_intel.c:468:22: warning: symbol
> 'microcode_intel_ops' was not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
applied to tip/x86/sparse-fixes, thanks Hannes!
Ingo
prev parent reply other threads:[~2008-11-26 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 19:49 Hannes Eder
2008-11-26 7:49 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126074938.GJ26036@elte.hu \
--to=mingo@elte.hu \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®