From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andi Kleen <andi@firstfloor.org>
Cc: eranian@googlemail.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mingo@elte.hu, x86@kernel.org,
eranian@gmail.com
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)
Date: Wed, 26 Nov 2008 23:05:29 +1100 [thread overview]
Message-ID: <20081126230529.ab37fb32.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20081126113309.GS6703@one.firstfloor.org>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi Andi,
On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@firstfloor.org> wrote:
>
> > + * x86 does not need extra alignment requirements for the sampling buffer
> > + */
> > +#define PFM_ARCH_SMPL_ALIGN_SIZE 0
> > +
> > +asmlinkage void pmu_interrupt(void);
> > +
> > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
>
> All these bitmap wrappers just seem like unnecessary obfuscation.
> Could you just drop them and call the standard functions directly?
These were added after comments from the PowerPC maintainer since how the
bitmaps are accessed needs to be arch specific.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-26 12:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 8:42 eranian
2008-11-26 11:33 ` Andi Kleen
2008-11-26 12:05 ` Stephen Rothwell [this message]
2008-11-26 12:22 ` Andi Kleen
2008-11-26 12:48 ` Stephen Rothwell
2008-11-26 13:32 ` Thomas Gleixner
2008-11-26 13:56 ` stephane eranian
2008-11-26 16:38 ` Thomas Gleixner
2008-11-27 9:51 ` stephane eranian
2008-11-27 10:56 ` Thomas Gleixner
2008-11-27 11:37 ` David Miller
2008-11-27 14:40 ` Thomas Gleixner
2008-11-26 13:35 ` Thomas Gleixner
2008-11-26 14:00 ` Andi Kleen
2008-11-26 21:18 ` Thomas Gleixner
2008-11-26 21:37 ` stephane eranian
2008-11-26 23:16 ` Thomas Gleixner
2008-11-27 9:38 ` stephane eranian
2008-11-26 22:54 ` Thomas Gleixner
2008-11-27 10:06 ` Andi Kleen
2008-11-27 10:09 ` stephane eranian
2008-11-27 10:29 ` Thomas Gleixner
2008-11-27 11:31 ` Andi Kleen
2008-11-27 11:35 ` stephane eranian
2008-11-27 11:42 ` David Miller
2008-11-27 11:49 ` Thomas Gleixner
2008-11-27 12:38 ` Andi Kleen
2008-11-27 12:31 ` stephane eranian
2008-11-27 12:46 ` Andi Kleen
2008-11-27 13:32 ` Thomas Gleixner
2008-11-27 13:37 ` stephane eranian
2008-11-27 13:51 ` Andi Kleen
2008-11-27 13:50 ` Andi Kleen
2008-11-27 11:52 ` Peter Zijlstra
2008-11-27 12:04 ` stephane eranian
2008-11-27 12:16 ` Peter Zijlstra
2008-11-27 12:32 ` Andi Kleen
2008-11-27 12:28 ` stephane eranian
2008-11-27 12:45 ` Andi Kleen
2008-11-27 13:30 ` stephane eranian
2008-11-27 13:49 ` Andi Kleen
2008-11-27 13:47 ` stephane eranian
-- strict thread matches above, loose matches on Subject: below --
2008-11-25 21:36 eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126230529.ab37fb32.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=eranian@gmail.com \
--cc=eranian@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®