From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Keith Packard <keithp@keithp.com>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] usb/serial/cp2101: Add support for cp2103 GPIO pins
Date: Thu, 27 Nov 2008 10:58:23 +0000 [thread overview]
Message-ID: <20081127105823.30786bf4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1227774576-5503-2-git-send-email-keithp@keithp.com>
On Thu, 27 Nov 2008 00:29:36 -0800
Keith Packard <keithp@keithp.com> wrote:
> The cp2103 is programmed the same as the cp2101/cp2102 except for the
> addition of a set of four GPIO pins which can be directly controlled by the
> host. Access to this is done through a custom ioctl.
Only concern I have is that a custom ioctl means every time a new serial
chip grows GPIO pins we end up with more ioctls.
We have an LED class driver which might perhaps do the job but isn't
really oriented that way but would keep the tty and gpio pins separate
and available to different applications at the same time.
Failing that a rename to make it a generic tty gpio ioctl might be more
futurerpoof ?
Alan
next prev parent reply other threads:[~2008-11-27 10:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 8:29 [PATCH] usb/serial: Add compat_ioctl pass-through Keith Packard
2008-11-27 8:29 ` [PATCH] usb/serial/cp2101: Add support for cp2103 GPIO pins Keith Packard
2008-11-27 10:58 ` Alan Cox [this message]
2008-11-27 18:20 ` Keith Packard
2008-11-27 18:41 ` Greg KH
2008-11-28 1:31 ` Keith Packard
2008-12-03 7:12 ` Greg KH
2008-12-03 8:11 ` Keith Packard
2008-11-27 14:31 ` [PATCH] usb/serial: Add compat_ioctl pass-through Arnd Bergmann
2008-11-27 18:27 ` Keith Packard
2008-11-28 11:43 ` Arnd Bergmann
2008-11-28 14:03 ` Alan Cox
2008-11-28 15:42 ` Arnd Bergmann
2008-11-28 22:28 ` Keith Packard
2008-11-28 22:33 ` Alan Cox
2008-11-29 1:02 ` Keith Packard
2008-11-29 1:10 ` Alan Cox
2008-11-29 1:23 ` Arjan van de Ven
2008-11-29 1:37 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127105823.30786bf4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®