From: walimis <walimisdev@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: about use wild cards for set_ftrace_filter and so on
Date: Thu, 27 Nov 2008 23:21:24 +0800 [thread overview]
Message-ID: <20081127152124.GA24616@ubuntu.mshome.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
Hi Steven and Ingo,
I encountered an issue when using ftrace.
We know that we can use wild cards to set set_ftrace_filter, but there's
problem when using such as "echo h* > /debug/tracing/set_ftrace_filter".
If there are files named with "h" prefix in current directory, echo "h*"
will echo these files' name to set_ftrace_filter, not "h*".
For example:
#cat /debug/tracing/available_filter_functions |grep ^hr |wc -l
23
#ls
#touch hraa hrdd
#ls
hraa hrdd
#echo hr* > /debug/tracing/set_ftrace_filter
#cat /debug/tracing/set_ftrace_filter
No output in /debug/tracing/set_ftrace_filter!
If we use "" to enclose wild cards, it works:
#ls
hraa hrdd
#echo "hr*" > /debug/tracing/set_ftrace_filter
#cat /debug/tracing/set_ftrace_filter |wc -l
23
This problem can lead to unexpected result if current directory has a
lot of files.
I suppose that we can add some notes to document, so a patch attached.
[-- Attachment #2: 0001-Impact-imporve-document.patch --]
[-- Type: text/x-diff, Size: 626 bytes --]
Impact: imporve document
Signed-off-by: walimis <walimisdev@gmail.com>
---
Documentation/ftrace.txt | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Documentation/ftrace.txt b/Documentation/ftrace.txt
index de05042..9735434 100644
--- a/Documentation/ftrace.txt
+++ b/Documentation/ftrace.txt
@@ -1251,6 +1251,9 @@ These are the only wild cards which are supported.
<match>*<match> will not work.
+Note: you'd better to use "" to enclose wild cards, otherwise in some
+case you can't get the correct result.
+
# echo hrtimer_* > /debug/tracing/set_ftrace_filter
Produces:
--
1.6.0.3
next reply other threads:[~2008-11-27 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 15:21 walimis [this message]
2008-11-27 15:34 ` Steven Rostedt
2008-11-27 15:50 ` walimis
2008-11-27 15:58 ` Frédéric Weisbecker
2008-11-27 16:21 ` Ingo Molnar
2008-11-28 2:32 ` [PATCH 1/1] ftrace: improve document walimis
2008-11-28 3:52 ` Steven Rostedt
2008-11-28 4:21 ` walimis
2008-11-28 6:55 ` Steven Rostedt
2008-11-28 12:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127152124.GA24616@ubuntu.mshome.net \
--to=walimisdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®