From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: aperture_64.c: clarify that too small aperture is valid reason for this code
Date: Fri, 28 Nov 2008 15:33:46 +0100 [thread overview]
Message-ID: <20081128143346.GF28138@elte.hu> (raw)
In-Reply-To: <20081126161527.GE1983@elf.ucw.cz>
* Pavel Machek <pavel@suse.cz> wrote:
> Clarify that too small aperture is valid reason for this code.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index 9a32b37..026fcfb 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -1,8 +1,9 @@
> /*
> * Firmware replacement code.
> *
> - * Work around broken BIOSes that don't set an aperture or only set the
> - * aperture in the AGP bridge.
> + * Work around broken BIOSes that don't set an aperture, only set the
> + * aperture in the AGP bridge, or set too small aperture.
> + *
applied to tip/x86/iommu, thanks Pavel!
That comment is indeed highly misleading - and sets the wrong mindset for
people who start reading this file. The list you add it to are indeed the
most common reasons for us to (re-)allocate the aperture.
Would you be interested in sending a patch for a full list of situations
where we declare the existing aperture invalid and reallocate it? It will
certainly help understanding the purpose and role of this file.
Ingo
prev parent reply other threads:[~2008-11-28 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 16:15 Pavel Machek
2008-11-26 16:39 ` Andi Kleen
2008-11-26 17:31 ` Pavel Machek
2008-11-28 14:33 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128143346.GF28138@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®