From: David Miller <davem@davemloft.net>
To: jirislaby@gmail.com
Cc: chas@cmf.nrl.navy.mil, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ATM: horizon, fix hrz_probe fail path
Date: Sat, 29 Nov 2008 20:43:41 -0800 (PST) [thread overview]
Message-ID: <20081129.204341.88799313.davem@davemloft.net> (raw)
In-Reply-To: <1227994465-20220-1-git-send-email-jirislaby@gmail.com>
From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 29 Nov 2008 22:34:25 +0100
> One fail path in hrz_probe omitted device disable. Fix it.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Applied, but please post all networking patches to
netdev@vger.kernel.org, in particular so that they
get properly tracked at:
http://patchwork.ozlabs.org/project/netdev/list/
I feel like I type this in at least 10 times a day, so
people please start making sure netdev is on the CC: for
all networking patches.
Thanks!
> ---
> drivers/atm/horizon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> index 6154123..6b969f8 100644
> --- a/drivers/atm/horizon.c
> +++ b/drivers/atm/horizon.c
> @@ -2705,7 +2705,7 @@ static int __devinit hrz_probe(struct pci_dev *pci_dev, const struct pci_device_
>
> /* XXX DEV_LABEL is a guess */
> if (!request_region(iobase, HRZ_IO_EXTENT, DEV_LABEL)) {
> - return -EINVAL;
> + err = -EINVAL;
> goto out_disable;
> }
>
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2008-11-30 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 21:34 Jiri Slaby
2008-11-30 4:43 ` David Miller [this message]
2008-11-30 8:23 ` [PATCH] MAINTAINERS: add netdev to ATM Jiri Slaby
2008-12-01 7:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081129.204341.88799313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®