From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755674AbYK2ARE (ORCPT ); Fri, 28 Nov 2008 19:17:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753037AbYK2AQw (ORCPT ); Fri, 28 Nov 2008 19:16:52 -0500 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:32966 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbYK2AQv (ORCPT ); Fri, 28 Nov 2008 19:16:51 -0500 X-Sasl-enc: 2kRnfb2T+8a+PF5E/DC9HAifw7osYCqE1H86++tU9kEW 1227917810 Date: Fri, 28 Nov 2008 22:16:47 -0200 From: Henrique de Moraes Holschuh To: Len Brown Cc: Sam Ravnborg , Stephen Rothwell , Len Brown , linux-next@vger.kernel.org, LKML , Randy Dunlap , x86@kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC PATCH] x86: create drivers/x86/ from drivers/misc/ Message-ID: <20081129001647.GA8699@khazad-dum.debian.net> References: <20081128213620.2ec593d4.sfr@canb.auug.org.au> <4930307C.30106@oracle.com> <20081129083550.3c23af37.sfr@canb.auug.org.au> <20081128223533.GA5175@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Nov 2008, Len Brown wrote: > > > Move x86 platform specific drivers from drivers/misc/ > > > to a new home under drivers/x86/. [...] > > We already have 81 one directory entries under drivers/ > > and with patch you open up for an additional > > directory for each arch - not elegant. > > I followed the example of drivers/s390/, > per Linus' suggestion. > > The other place that seemed to suggest itself was > arch/x86/drivers/, as we already have: > > arch/um/drivers/ > arch/sh/drivers/ > arch/cris/*/drivers/ IMHO, from a purely "tree organization" point of view, it would be best if arch-specific platform drivers were under drivers/platform//. And arch/ be left for the core arch-specific stuff. Whether that would work well, when arch maintenance factors are taken into account, I don't know. > > As it is today (before this patch) the directories unider > > drivers/ said what the drivers was used for - which is logical. > > > > But with this new arch specific directory it is no longer obvious > > is a driver should be located under say drivers/net/* or > > drivers/arm/* in case it is a arm specific driver. drivers/platform/ would help in that regard, I think. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh