From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Julia Lawall <julia@diku.dk>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/pci/hotplug: Add missing pci_dev_get
Date: Mon, 1 Dec 2008 12:30:49 -0800 [thread overview]
Message-ID: <200812011230.49406.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0811230907370.28343@ask.diku.dk>
On Sunday, November 23, 2008 12:08 am Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> pci_get_slot does a pci_dev_get, so pci_dev_put needs to be called in an
> error case.
>
> An alterative would be to move the test_and_set_bit before the call to
> pci_get_slot.
>
> The problem was fixed using the following semantic patch.
> (http://www.emn.fr/x-info/coccinelle/)
Applied to my linux-next branch, thanks. Btw, I've seen quite a few of these
Coccinelle related patches fly by, but I haven't seen an introduction of the
tool posted to lkml. Did I miss it? Or maybe it just went to the janitors
list? If not, it seems like it might be a worthwhile thing to describe for
people...
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2008-12-01 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 8:08 Julia Lawall
2008-12-01 20:30 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812011230.49406.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®