Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng

[Hans Verkuil <hverkuil@xs4all.nl>]

On Monday 01 December 2008 13:27:07 Mauro Carvalho Chehab wrote:
> On Mon, 1 Dec 2008 12:46:08 +0100
>
> Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > Hi Mauro,
> >
> > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-ng for
> > the following:
> >
> > - v4l2: add v4l2_device and v4l2_subdev structs to the v4l2
> > framework. - v4l2-common: add i2c helper functions
> > - cs53l32a: convert to v4l2_subdev.
> > - cx25840: convert to v4l2_subdev.
> > - m52790: convert to v4l2_subdev.
> > - msp3400: convert to v4l2_subdev.
> > - saa7115: convert to v4l2_subdev.
> > - saa7127: convert to v4l2_subdev.
> > - saa717x: convert to v4l2_subdev.
> > - tuner: convert to v4l2_subdev.
> > - upd64031a: convert to v4l2_subdev.
> > - upd64083: convert to v4l2_subdev.
> > - vp27smpx: convert to v4l2_subdev.
> > - wm8739: convert to v4l2_subdev.
> > - wm8775: convert to v4l2_subdev.
> > - ivtv/ivtvfb: convert to v4l2_device/v4l2_subdev.
> >
> > All points raised in reviews are addressed so I think it is time to
> > get this merged so people can start to use it.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@skynet.be>
> > Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Reviewed-by: Andy Walls <awalls@radix.net>
> > Reviewed-by: David Brownell <david-b@pacbell.net>
> >
> > Once this is in I'll start on converting the other i2c drivers.
>
> Hmm.. wouldn't this break the other drivers that use the converted
> i2c drivers (for example saa7115 and msp3400 are used for other
> drivers, like em28xx and bttv).

No, see v4l2_subdev_command() in v4l2-subdev.c: this adds the required 
backwards compatibility. It can be removed once everyone uses the new 
calling convention, but until that time it will take care of this. 
That's the nice thing about it: you can do the conversion step by step 
without worrying about breaking existing drivers.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG