mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Liming Wang <liming.wang@windriver.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] function trace: fix a bug of single thread function trace
Date: Tue, 2 Dec 2008 09:23:37 +0100	[thread overview]
Message-ID: <20081202082337.GB5424@elte.hu> (raw)
In-Reply-To: <1228185188-10422-1-git-send-email-liming.wang@windriver.com>


* Liming Wang <liming.wang@windriver.com> wrote:

> Impact: fix a bug in ftrace_update_pid_func
> 
> When disabling single thread function trace using
> "echo -1 > set_ftrace_pid", the normal function trace
> has to restore to original function, otherwise the normal
> function trace will not work well.
> Without this commit, something like below:
> 
> 	$ ps |grep 850
> 	  850 root      2556 S    -/bin/sh
> 	$ echo 850 > /debug/tracing/set_ftrace_pid
> 	$ echo function > /debug/tracing/current_tracer
> 	$ echo 1 > /debug/tracing/tracing_enabled
> 	$ sleep 1
> 	$ echo 0 > /debug/tracing/tracing_enabled
> 	$ cat /debug/tracing/trace_pipe |wc -l
> 	59704
> 	$ echo -1 > /debug/tracing/set_ftrace_pid
> 	$ echo 1 > /debug/tracing/tracing_enabled
> 	$ sleep 1
> 	$ echo 0 > /debug/tracing/tracing_enabled
> 	$ more /debug/tracing/trace_pipe
> 		<====== nothing output now!
> 			it should output trace record.
> 
> Signed-off-by: Liming Wang <liming.wang@windriver.com>
> ---
>  kernel/trace/ftrace.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)

applied to tip/tracing/ftrace, thanks!

	Ingo

      reply	other threads:[~2008-12-02  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02  2:33 Liming Wang
2008-12-02  8:23 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081202082337.GB5424@elte.hu \
    --to=mingo@elte.hu \
    --cc=liming.wang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®