Re: mmotm 2008-11-26-17-00 uploaded (hwmon / dev_attr_name)

[Rodolfo Giometti <giometti@enneenne.com>]

On Mon, Dec 01, 2008 at 10:37:41AM -0800, Andrew Morton wrote:

> I'll sort it out.

Ok. :)

> > > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_dcd_change':
> > > drivers/pps/clients/pps-ldisc.c:32: warning: cast from pointer to integer of different size
> > > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_open':
> > > drivers/pps/clients/pps-ldisc.c:77: warning: cast to pointer from integer of different size
> > > drivers/pps/clients/pps-ldisc.c:82: warning: cast from pointer to integer of different size
> > > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_close':
> > > drivers/pps/clients/pps-ldisc.c:91: warning: cast from pointer to integer of different size
> > > 
> > > 
> > > For the ->disc_data warnings you could perhaps just make all the
> > > relevant scalar types `long', not `int'.
> > 
> > But doing like this will breaks 32bit archs... =:-o
> 
> I don't think so.  sizeof(long) == sizeof(int) on 32-bit.

But "%d" != "%ld". :)

However this is a minor issue... I'm going to propose a patch ASAP.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti