From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>,
Jeff Garzik <jgarzik@redhat.com>,
Alexandru Romanescu <a_romanescu@yahoo.co.uk>
Subject: Re: [PATCH 1/1] ATA: piix, fix pointer deref on suspend
Date: Wed, 3 Dec 2008 10:13:42 +0000 [thread overview]
Message-ID: <20081203101342.5041f3fb@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1228292026-23586-1-git-send-email-jirislaby@gmail.com>
On Wed, 3 Dec 2008 09:13:46 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:
> Hi,
>
> I've found this issue in the mmotm 2008-12-02-17-08.
>
> --
>
> Commit
> ata_piix: add borked Tecra M4 to broken suspend list
> introduced DMI variables checking, but they can be null, so that
> we possibly dereference null.
>
> Check if they are null and avoid checks in that case.
Gak.. Add some kind of helper to the dmi code to do this and do the
comparison.
next prev parent reply other threads:[~2008-12-03 10:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 8:13 Jiri Slaby
2008-12-03 9:04 ` Tejun Heo
2008-12-03 10:13 ` Alan Cox [this message]
2008-12-03 10:39 ` Tejun Heo
2008-12-09 5:47 ` Jeff Garzik
2008-12-09 20:52 ` [PATCH 1/2] DMI: add dmi_match Jiri Slaby
2008-12-09 20:52 ` [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend Jiri Slaby
2008-12-09 21:29 ` Jeff Garzik
2008-12-09 22:06 ` Jiri Slaby
2008-12-10 13:07 ` [PATCH 1/2] DMI: add dmi_match Jiri Slaby
2008-12-10 13:07 ` [PATCH 2/2] ATA: piix, cleanup dmi strings checking Jiri Slaby
2008-12-29 12:41 ` [PATCH 1/2] DMI: add dmi_match Jeff Garzik
2008-12-11 20:27 ` [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend Andrew Morton
2008-12-11 20:34 ` Jiri Slaby
2008-12-09 20:59 ` [PATCH 1/2] DMI: add dmi_match Alan Cox
2008-12-10 2:00 ` Tejun Heo
2008-12-11 20:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203101342.5041f3fb@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=a_romanescu@yahoo.co.uk \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@redhat.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®