From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756700AbYLDNSN (ORCPT ); Thu, 4 Dec 2008 08:18:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752196AbYLDNR5 (ORCPT ); Thu, 4 Dec 2008 08:17:57 -0500 Received: from vps1.tull.net ([66.180.172.116]:38952 "HELO vps1.tull.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751944AbYLDNR5 (ORCPT ); Thu, 4 Dec 2008 08:17:57 -0500 Date: Fri, 5 Dec 2008 00:17:52 +1100 From: Nick Andrew To: Jiri Kosina Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] trivial: printk: fix indentation of new_text_line declaration Message-ID: <20081204131752.GA16905@mail.local.tull.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SMTPD: qpsmtpd/0.26, http://develooper.com/code/qpsmtpd/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 04, 2008 at 12:44:34PM +0100, Jiri Kosina wrote: > I have just come across bogus indentation of new_text_line declaration. I > have applied the patch below to trivial tree. If the indentation had some > specific non-obvious purpose and was done intentionally this way, please > let me know :) That's cool. Ingo tweaked my patch and moved the static declaration outside the function and mistakenly left the indent in place. I'm actually not too happy about new_text_line being a static; I may well submit a patch to fix that. But in the meantime, fixing the indent is fine. > From: Jiri Kosina > Subject: trivial: printk: fix indentation of new_text_line declaration > > Remove bogus indentation of new_text_line declaration introduced in > commit ac60ad741. > > Signed-off-by: Jiri Kosina Acked-by: Nick Andrew Nick.